247972 - Firefox crashes if you quit while downloading an extension

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Laurent Duperval]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616 Firefox/0.9
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040616 Firefox/0.9

When I try to install an extension, if I quit before a download is completed,
Firefox will show me the "Exiting will cancel <n> downloads" dialog. If I select
cancel, the dialog will pop up again and again until Firefox crashes.

Reproducible: Always
Steps to Reproduce:
1. Select an extension to install
2. CLick the "Install now" link. On my system, this can take a looooong time (3
minutes or more)
3. Before the extension is downloaded, try to exit
4. A confirmation dialog comes up
5. Select he cancel button until Firefox crashes (on my system, between 3 and 5
clicks).

Actual Results:  
A crash

Expected Results:  
Anything but a crash. :-)

I use Gentoo, so this is a Gentoo build, not the binary from Mozilla.org.

Comment 1

[Ali Ebrahim]

Extension downloads now occur in the Extension manager. Moving to that component.

Comment 2

[Adam Hauner]

Laurent Duperval: Could you provide TalkBack incident ID?

Comment 3

[Laurent Duperval]

I don't have talkback installed. I'll try to recompile it with talkback enabled.

Comment 4

[Adam Hauner]

Laurent: Maybe you should try build provided by Mozilla.org. I'm not sure, if
Talkback report from home-compiled buid will be usefull.

Comment 5

[Laurent Duperval]

Hmmmm... Maybe I'll try to install the Mozilla build in a separate directory
just for this. I'll try to get something to you today.

L

Comment 6

[Ali Ebrahim]

(In reply to comment #3)
> I don't have talkback installed. I'll try to recompile it with talkback enabled.

You can't. Talkback is only present in mozilla.org builds.

Comment 7

[Asa Dotzler [:asa]]

I've reproduced this and sent in talkback reports. As soon as the DB is back up,
I'll get those reports and attach them here. 

Comment 8

[Benjamin Smedberg]

Is this File -> Exit or closing all the open windows?

Comment 9

[Asa Dotzler [:asa]]

File -> Exit

Comment 10

[chris hofmann]

lets try and get this before PR

Comment 11

[Benjamin Smedberg]

Asa: what is the expected behavior? a warning dialog (would it be OK to re-use
the "unfinished downloads" dialog)?

Comment 12

[Jay Patel [:jay]]

Has anyone been able to reproduce this with Firefox 1.0 PR1 or a recent nightly?
 If so, can you please post your Talkback ID?  Thanks.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Can't reproduce, new brunk tree, fc3t2

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Until there's a way I can reproduce or a stack we can work with, -

Comment 15

[Michael T. Babcock]

It didn't crash for me, but with my copy of 1.0 for Linux from mozilla.org, if I
try to exit while four extensions are waiting to download, I get four request
boxes asking if I'm sure I want to exit and cancel the downloads; each time I
say cancel, another appears, presumably one for each download.

I don't know if these are related or if I should file a seperate bug.

Comment 16

[Robert Strong (they/them - no direct email)]

I don't crash with Linux using a recent build - Laurent, can you still reproduce?

Comment 17

[Laurent Duperval]

No I can't for two reasons:

- Downloading is now much(!) faster
- The download window seems to be modal, so I can't exit anymore while downloading.

L

Comment 18

[Robert Strong (they/them - no direct email)]

This is WFM. Can anyone still reproduce this on Firefox 1.5?

Comment 19

[Robert Strong (they/them - no direct email)]

No response, resolving WFM.