Closed
Bug 248010
Opened 21 years ago
Closed 21 years ago
Remove unused |nsSHistory::PrintHistory()|
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
INVALID
People
(Reporter: sgautherie, Assigned: sgautherie)
Details
Attachments
(1 file)
3.08 KB,
patch
|
Details | Diff | Splinter Review |
From bug 78672 comment 28 and bug 78672 comment 29:
{{ <http://lxr.mozilla.org/mozilla/search?string=PrintHistory>
PrintHistory
/content/xml/tests/docbook.css, line 342 -- PrintHistory {
/xpfe/components/shistory/src/nsSHistory.cpp, line 281 -- nsSHistory::PrintHistory()
/xpfe/components/shistory/src/nsSHistory.h, line 85 -- nsresult PrintHistory();
}}
Assignee | ||
Comment 1•21 years ago
|
||
Assignee: nobody → gautheri
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•21 years ago
|
||
Comment on attachment 151397 [details] [diff] [review]
(Av1) <nsSHistory.*>
I have no compiler: Could you compile (with DEBUG=ON !) / review this patch ?
Thanks.
I'm asking you directly on this one,
because it's a line removal only,
and I wonder if it could be a WontFix...
Attachment #151397 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 3•21 years ago
|
||
Bug 78672 has a misleading title. You can actually build optimized, symbols and
debug independently. The default is optimized, no symbols, no debug; this
function will not get compiled in this case and therefore is not relevant.
Relevant .mozconfig/configure options:
--disable-optimize
--enable-debug (#define DEBUG plus also enables symbols by default)
--enable-debugger-info-modules=yes (enables symbols but not DEBUG)
--enable-debugger-info-modules=no (disables --enable-debug symbols)
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → INVALID
Updated•20 years ago
|
Attachment #151397 -
Flags: review?(neil.parkwaycc.co.uk) → review?
Updated•20 years ago
|
Attachment #151397 -
Flags: review?
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in
before you can comment on or make changes to this bug.
Description
•