248307 - lack of {} in mozilla\extensions\universalchardet\src\nsEUCJPProber.cpp:80

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Vladimir]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0) Opera 7.51  [en]
Build Identifier: All

In source code mDistributionAnalyser.HandleOneChar(aBuf+i-1, charLen); ecexuted 
always despite i==0
      if (i == 0)
      {
        mLastChar[1] = aBuf[0];
        mContextAnalyser.HandleOneChar(mLastChar, charLen);
        mDistributionAnalyser.HandleOneChar(mLastChar, charLen);
      }
      else
        mContextAnalyser.HandleOneChar(aBuf+i-1, charLen);
        mDistributionAnalyser.HandleOneChar(aBuf+i-1, charLen);
	  
must be 
      if (i == 0)
      {
        mLastChar[1] = aBuf[0];
        mContextAnalyser.HandleOneChar(mLastChar, charLen);
        mDistributionAnalyser.HandleOneChar(mLastChar, charLen);
      }
      else{
        mContextAnalyser.HandleOneChar(aBuf+i-1, charLen);
        mDistributionAnalyser.HandleOneChar(aBuf+i-1, charLen);
      }


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
Wrong work of nsEUCJPProber in universal charset detector

Comment 1

[Vladimir]

Attachment: Just add {}

Comment 2

[Adam Hauner]

Comment on attachment 151524 [details] [diff] [review]
Just add {}

Simply fix of missing {} by Vladimir.

Comment 3

[Adam Hauner]

Timeless: Should I ask you for check in r+sr patch 151524 to tree?

Comment 4

[timeless]

mozilla/extensions/universalchardet/src/nsEUCJPProber.cpp 	1.7

I changed the bracing to match the surrounding code (i hope). if this is fixed
to your satisfaction, please resolve it.

Comment 5

[Adam Hauner]

http://lxr.mozilla.org/seamonkey/source/extensions/universalchardet/src/nsEUCJPProber.cpp#74
Timeless: Thanx! Could you also check r+sr patch for bug 228542?
Marking FIXED.