248351 - Port connection pref UI to Sunbird to enable the use of a proxy server

Status: RESOLVED DUPLICATE of bug 278733

(Calendar :: General, defect)

Description

[James Montaldi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040306 Mozilla Sunbird/0.1.1+

There's no UI to enter proxy server information in Sunbird.

The work around was to copy the following 3 lines from my prefs.js in my FireFox
profile to prefs.js in Sunbird profile:

user_pref("network.proxy.http", my proxy server);
user_pref("network.proxy.http_port", port number);
user_pref("network.proxy.type", 1);


Reproducible: Always
Steps to Reproduce:
1. Install Sunbird
2. Don't edit prefs.js 
3. Subscribe to a remote calendar 


Actual Results:  
If you use a proxy server Sunbird won't find the calendar.

(If you don't use a proxy server it works fine)

Expected Results:  
Subscribed to the remote calendar.

Comment 1

[Josh Benjamin]

I confirm this bug (unofficially)

Comment 2

[Justin Wood (:Callek)]

confirming, original report is right, and based on c#1

This is not to say that *I* will be working on it, (I dont personally have time
right now) leaving assigned to mostafah.

Comment 3

[Simon Paquet [:sipaq]]

Michiel, Mostafah, 

as far as I can see, we already have the necessary prefs in all.js:

pref("network.proxy.autoconfig_url",        "");
pref("network.proxy.type",                  0);
pref("network.proxy.ftp",                   "");
pref("network.proxy.ftp_port",              0);
pref("network.proxy.gopher",                "");
pref("network.proxy.gopher_port",           0);
pref("network.proxy.http",                  "");
pref("network.proxy.http_port",             0);
pref("network.proxy.ssl",                   "");
pref("network.proxy.ssl_port",              0);
pref("network.proxy.socks",                 "");
pref("network.proxy.socks_port",            0);
pref("network.proxy.socks_version",         5);
pref("network.proxy.socks_remote_dns",      false);
pref("network.proxy.no_proxies_on",         "localhost, 127.0.0.1");
pref("network.proxy.failover_timeout",      1800); // 30 minutes

We just lack the UI for it. Would you mind if I try to port the UI over from
Firefox?

Another question, will a http proxy also allow the connection via WebDAV, or
should we file a bug against Necko to add WebDAV support for proxying?

Comment 4

[Mostafa Hosseini]

(In reply to comment #3)
> We just lack the UI for it. Would you mind if I try to port the UI over from
> Firefox?

No that would be great. But isn't there a request or bug that would want the UI
to be moved into toolkit so all apps can use it, preventing duplication?

> Another question, will a http proxy also allow the connection via WebDAV, or
> should we file a bug against Necko to add WebDAV support for proxying?

webdav goes through http so once http proxy is supported, it will be fine. But
what about ftp?

Comment 5

[Simon Paquet [:sipaq]]

>> We just lack the UI for it. Would you mind if I try to port the UI over from
>> Firefox?
> 
> No that would be great. But isn't there a request or bug that would want the 
> UI to be moved into toolkit so all apps can use it, preventing duplication?

I couldn't find such a bug. And even if there were such a bug, that shouldn't
prevent us from doing this to improve the Sunbird experience for our users with
proxies.

>> Another question, will a http proxy also allow the connection via WebDAV, or
>> should we file a bug against Necko to add WebDAV support for proxying?
> 
> webdav goes through http so once http proxy is supported, it will be fine. But
> what about ftp?

The pref UI allows for the setting of a ftp proxy.

Right now, the porting is mostly done on my machine, but there are some hickups
which I don't know how to solve. It will probably require someone with some good
knowledge of JS to figure that stuff out.

Await my patches and then we'll improve the code based on what I've managed so far.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Why not do the right thing right away, and prot to toolkit? porintg to sunbird
first just doubles the work

Comment 7

[Simon Paquet [:sipaq]]

*** This bug has been marked as a duplicate of 278733 ***

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!