248538 - Opening Internet Shortcuts (.url files) doesn't work (using File | Open or file: protocol)

Status: RESOLVED INVALID

(Firefox :: File Handling, defect, P3)

Description

[Jungshik Shin]

This is the firefox counterpart of bug 69114. cbie isn't interested in porting
his patch to firefox. I'm filing this bug separately to make sure that it's
fixed in firefox as well.

Comment 1

[Ali Ebrahim]

Stealing summary from bug 69114.

Comment 2

[Blake Ross]

We've got the fix and we want IE users, let's get this in.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

note that the only thing that'd require porting is the nsBookmarksService patch.
and that's really just a bit of code cleanup.

(put differently, doing this porting work on the branch is probably a waste of time)

Comment 4

[(not currently active) Ted Mielczarek]

*** Bug 250217 has been marked as a duplicate of this bug. ***

Comment 5

[Blake Ross]

Can someone actually reproduce this in Firefox? I went and applied the patch,
then just tried it in a nightly on a whim and it worked anyways...

Comment 6

[Mike Connor [:mconnor]]

*** Bug 253050 has been marked as a duplicate of this bug. ***

Comment 7

[Blake Ross]

I need QA input here before I can do anything else.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

The three sites I tested (www.dabs.com/uk, www.amazon.com, www.mozilla.org)
where all loaded from the .url file rather than displaying the contents. I made
the shortcuts by dragging and dropping from the IE address bar.

There are two issues to report though: 

1, CSS styles are not being applied, so the layout varies from slightly to very
munged (respectively).
2, The address is set so something on the local disk rather than the website
loaded. eg:
file:///C:/Documents%20and%20Settings/Username/Local%20Settings/Temporary%20Internet%20Files/Content.IE5/Q121J39N/www.mozilla%5B1%5D

Strangely, drag and drop of the url file on the window works just fine.

Comment 9

[Ali Ebrahim]

Yeah, I'm seeing part 2 of comment 8. We should try and get this in for Firefox 1.1.

Comment 10

[zanezane.net]

This bug is back in Firefox 2.0! I don't know if I should fill a new one or resume this bug?

Comment 11

[Dave Townsend [:mossop]]

*** Bug 361847 has been marked as a duplicate of this bug. ***

Comment 12

[Chris Lawson (gone)]

It would appear that either double-clicking or drag-n-drop (or possibly both) are also broken, at least on Mac. See bug 361847's description for more.

Fixing platform/OS too.

Comment 13

[Phil Ringnalda (:philor)]

Some of comment 7's QA, indeed.

Per comment 0, this bug is about porting the fix in bug 69114. That bug made some core changes in netwerk/, and changed the suite's profile import code to call into netwerk to resolve .url files. If anyone intended to port the core changes to whatever branch we were on at the time, it's far too late now, and otherwise we've long since gotten them from netwerk/. I filed bug 361858 about changing our profile import code, to get that out of this confused bug.

Comment 8 is indeed right that it works oddly, if not wrongly, but that's Core: Networking:File, not our File Handling, and not what this started out as: I filed bug 361857 on that.

And that leaves this bug with nothing left to be (once I reopen bug 361847, since that's a request for Mac file protocol handling that currently doesn't exist), so, INVALID, and off to other bugs that know what they are and what they want.