248579 - [regression]prelight text invisible in high-contrast inverse themes

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Ginn Chen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040624 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040624 Firefox/0.8.0+

regression of bug 237535

"prelit" text is invisible (i.e. text on buttons and other UI elements which are
"prelit" by the presence of the mouse of other user activity) when inverse
themes are selected. 

To reproduce:
on GNOME, select the HighContrastInverse theme from "Desktop Preferences->Theme".
Start mozilla

Note that if the mouse is moved over UI buttons ("Back', 'Reload', etc. and
'Home', 'Bookmarks', etc. in the personal toolbar), the text on these elements
is invisible since it's displayed on white text on a white background.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Ginn Chen]

Attachment: patch

patch from bug 237535

Comment 2

[Ginn Chen]

Attachment: gnomestripe_button.css

add button.css to gnomestripe

Comment 3

[Ginn Chen]

Attachment: gnomestripe_toolbarbutton

add toolbarbutton.css to gnomestripe

Comment 4

[Ginn Chen]

Comment on attachment 151667 [details] [diff] [review]
gnomestripe_button.css

patch from bug 237535

Comment 5

[Ginn Chen]

Comment on attachment 151668 [details] [diff] [review]
gnomestripe_toolbarbutton

patch from bug 237535

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 151666 [details] [diff] [review]
patch

>+*+ skin/classic/global/toolbarbutton.css
>+*+ skin/classic/global/button.css

Please don't preprocess these (remove the *).  We're trying not to preprocess
css files if possible because of the risk of it stripping out id selectors...
and in this case you can simply remove the #ifdefs since this is gtk2 only.

Looks good other than that.

Comment 7

[Ginn Chen]

Comment on attachment 151667 [details] [diff] [review]
gnomestripe_button.css

-button:hover:active,
+button[buttondown="true"],

this change should not be there.

I updated it on bug 248578.

should add
+button:hover:active[disabled="true"] {
+  color: GrayText;
+}

Need I repost it?

Comment 8

[Mike Connor [:mconnor]]

(In reply to comment #7)
> (From update of attachment 151667 [details] [diff] [review])
> -button:hover:active,
> +button[buttondown="true"],
> 
> this change should not be there.
> 
> I updated it on bug 248578.
> 
> should add
> +button:hover:active[disabled="true"] {
> +  color: GrayText;
> +}
> 
> Need I repost it?
> 


Nope, that's fine.  Whoever commits this should also commit to the aviary branch
as well, since that'll need the fix too for Firefox 1.0

Comment 9

[Mike Connor [:mconnor]]

checked in on aviary branch, but this won't apply cleanly to trunk.  Getting all
sorts of fun errors.

Ginn, can you provide a single diff (using -N to include the added files and
addressing the review comments) and I'll check this in tomorrow?  Sorry about
the delay on this, work has been unreal.

Comment 10

[Ginn Chen]

I think you just missed one file,
mozilla/browser/themes/winstripe/browser/browser.css.

It should be committed. The patch posted is OK for this file.

I guess I can't do diff -N, because I've on write permisson.

Thank you, Mike.

Comment 11

[Mike Connor [:mconnor]]

the lines removed from that file in the patch no longer exist on aviary or
trunk, as far as I can tell.  Please try building from CVS to verify this is
actually fixed and then resolve it please :)

Comment 12

[Ginn Chen]

1. mozilla/browser/themes/winstripe/browser/browser.css is not patched.
RCS file: /cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v
Working file: browser.css
head: 1.2
branch:
locks: strict
access list:
symbolic names:
        THUNDERBIRD_0_7_1_RELEASE: 1.1.2.2
        FIREFOX_0_9_1_RELEASE: 1.1.2.2
        FIREFOX_0_9_1_BRANCH: 1.1.2.2.0.2
        FORMS_20040621_BRANCH: 1.2.0.2
        FORMS_20040621_BASE: 1.2
        FIREFOX_0_9_RELEASE: 1.1.2.2
        FIREFOX_0_9_RC1: 1.1.2.2
        AVIARY_1_0_20040515_BRANCH: 1.1.0.2
keyword substitution: kv
total revisions: 5;     selected revisions: 5
description:
----------------------------
revision 1.2
date: 2004/06/17 23:01:10;  author: ben%bengoodger.com;  state: Exp;  lines: +843 -0
land winstripe on trunk

2.I don't know where your gnomestripe/button.css gnomestripe/toolbarbutton.css
come from, they're not my version.
Maybe your mail client played tricks.

For example, in your file, there are
button {
  -moz-appearance: button;
  -moz-user-focus: ignore;
  margin: 6px;
  min-width: 6.3em;
  -moz-appearance: button;
 padding: 0px 4px;
  color: #000000;             //Hardcode color, should be ButtonText
}

There are so many differs.
All fun errors come from them.

I repost these 3 files here, please correct them ASAP.

Comment 13

[Ginn Chen]

Attachment: mozilla/browser/themes/winstripe/browser/browser.css

Comment 14

[Ginn Chen]

Attachment: mozilla/toolkit/themes/gnomestripe/global/button.css

mozilla/toolkit/themes/gnomestripe/global/button.css

Comment 15

[Ginn Chen]

Attachment: mozilla/toolkit/themes/gnomestripe/global/toolbarbutton.css

mozilla/toolkit/themes/gnomestripe/global/toolbarbutton.css

Comment 16

[Ginn Chen]

Mike, I think you messed pinstripe and winstripe.
Oops, really fallible.

Comment 17

[Mike Connor [:mconnor]]

ugh, that's very possible.  Will fix this ASAP.

Comment 18

[Mike Connor [:mconnor]]

/me bangs head on table.  I knew I'd screw up one checkin out of the 13 or 14 I
did last night. :)

Comment 19

[Mike Connor [:mconnor]]

oh, and the updated fixes were checked in, please verify since I haven't exactly
had enough sleep to self-verify ;)

Comment 20

[Ginn Chen]

Fixed, thanks, Mike.