24864 - Int. chars dont get correctly into the "Save Attachment" dialog

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P3)

Description

[Henrik Gemal]

If I have a attachment called "æøå.jpg" and press on the file name in the 
dropdown attachment box when reading mail the filename get translated into:
æøå.jpg

using 2000012208

Comment 1

[nhottanscp]

Reassign to ducarroz.

Comment 2

[Jean-Francois Ducarroz]

Looks like we need some more translation to platform specific characters set.
Jeff, do you have another bug like that?

Comment 3

[Makoto Kato [:m_kato]]

I think that this issue is as same as BUG 22863 ??

Comment 4

[nhottanscp]

The file widget problem 22863/23384 is fixed (at least for windows). But I still 
don't see it correctly. Could be UTF-8 to UCS2 conversion problem (as the 
European characters got doubled from its original size, which happens in UTF-8).

Comment 5

[Jean-Francois Ducarroz]

Accepting

Comment 6

[Jean-Francois Ducarroz]

Here is the fix:
Index: nsMessenger.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/base/src/nsMessenger.cpp,v
retrieving revision 1.138
diff -r1.138 nsMessenger.cpp
421c421,439
<           rv = fileSpec->ChooseOutputFile("Save Attachment", nsUnescape(unescapedDisplayName),
---
>           nsUnescape(unescapedDisplayName);
> 
>           /* we need to convert the UTF-8 fileName to platform specific character set.
>              The display name is in UTF-8 because it has been escaped from JS
>           */ 
>           
>           nsAutoString tempStr;
>           rv = ConvertToUnicode("UTF-8", unescapedDisplayName, tempStr);
>           if (NS_SUCCEEDED(rv))
>           {
>             char * tempCStr;
>             rv = ConvertFromUnicode(nsMsgI18NFileSystemCharset(), tempStr, &tempCStr);
>             if (NS_SUCCEEDED(rv))
>             {
>                 nsCRT::free(unescapedDisplayName);
>                 unescapedDisplayName = tempCStr;
>             }
>           }      
>           rv = fileSpec->ChooseOutputFile("Save Attachment", unescapedDisplayName,
1515c1533
<       rv = nsMsgI18NSaveAsCharset(TEXT_PLAIN, (const char *)nsAutoCString(msgCompFileSystemCharset()), 
---
>       rv = nsMsgI18NSaveAsCharset(TEXT_PLAIN, (const char *)nsAutoCString(nsMsgI18NFileSystemCharset()), 

Comment 7

[Jean-Francois Ducarroz]

moving to M15

Comment 8

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 9

[Henrik Gemal]

seems to be working now...:)

Comment 10

[Jean-Francois Ducarroz]

sure it's working, I have tested it against French 8 bits characters. Sorry, I haven't tested it against Danish words ;-
)

Comment 11

[Henrik Gemal]

Verified!

Comment 12

[Katsuhiko Momoi]

gemal. You should take credit for doing this. 
Changed the QA contact to [e-mail]

Comment 13

[Jean-Francois Ducarroz]

Does somebody have verifiy it against japanese characters?

Comment 14

[Katsuhiko Momoi]

Should have added this comment before.
The file name is shown correctly when it is in Japanese
also.