248675 - radio button with disabled="false" attribute rendered incorrectly

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Nickolay_Ponomarev]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9 (best browser EVAR1!!)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040514

In the Modern theme a radio button with disabled="false" attribute (ie. <radio
disabled="false" ... />) looks the same when selected and when not selected.

This is because of incorrect rule in chrome://global/skin/radio.css (IMHO)
It reads:
---------
radio[disabled] > .radio-check {
  list-style-image: url("chrome://global/skin/radio/radio-dis.gif") !important;
}
---------
and it should be:
---------
radio[disabled="true"] > .radio-check {
  list-style-image: url("chrome://global/skin/radio/radio-dis.gif") !important;
}


Reproducible: Always
Steps to Reproduce:
1. go to http://quicknote.mozdev.org/
2. install QuickNote 0.5.9.1 or earlier
3. open QN's settings window

Actual Results:  
send to tab 1 radio button looks like it is not selected, though it is.


this has also been seen with
Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7) Gecko/20040618

Comment 1

[Andreas Kunz]

Confirming. 
This is not only a rendering problem, but also prevents the user from activating
the given radio element (but this problem is solved with the corrected style).
Testcase and patch coming...

Nickolay: thank you very much for finding the exact problem causing this!!

Comment 2

[Andreas Kunz]

Attachment: testcase

Comment 3

[Andreas Kunz]

Attachment: patch

Patch as proposed in the bug description.
Tested, works fine.
Other places like
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/mac/radio.css#85
already get this right. Seems to be the only place where it's wrong.

Comment 4

[Andreas Kunz]

Comment on attachment 151744 [details] [diff] [review]
patch

Requesting r= from Neil.

Comment 5

[Andreas Kunz]

Comment on attachment 151744 [details] [diff] [review]
patch

Requesting sr= from alecf.

Comment 6

[Andreas Kunz]

Comment on attachment 151744 [details] [diff] [review]
patch

Changing sr= request to jag.

Comment 7

[jag (Peter Annema)]

Comment on attachment 151744 [details] [diff] [review]
patch

sr=jag

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in themes/modern/global/radio.css;
/cvsroot/mozilla/themes/modern/global/radio.css,v  <--  radio.css
new revision: 1.23; previous revision: 1.22
done