248749 - Progress Bar fails to refresh after page load.

Status: RESOLVED DUPLICATE of bug 209330

(SeaMonkey :: UI Design, defect)

Description

[Chris Waldron]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616

This bug relates to 247987.  After changing the code based on the suggested
solution, while the page now appears to load correctly, the progress bar does
not refresh after the page loads.  In the attachment you can see the problem in
the enclosed mozbug.png.

  

Reproducible: Always
Steps to Reproduce:
1. Unzip the attachement
2. Run the enclosed WebFrom1.aspx.htm file. 
   WebFrom1.aspx.htm is the rendered page source.
3. Page will load but the progress bar fails to refresh.

Actual Results:  
Page load without errors but the progress bar fails to refresh.

Expected Results:  
Page load successfully and the progress bar refresh.

[1] Refer to bug 247987 for background information and other attachments.

[2] The enclosed scripts deprecated the property copying that was a source of
the problem in bug 247987.  It now calls the constructor function along the
inheritance chain to set up the current instance.

[3] Works normally in version 1.6

Comment 1

[Chris Waldron]

Attachment: Scripts for repoducing the bug.

WebForm1.aspx.htm is the rendered page source that you can use to repro the
bug.
mozbug.png is an illustration of the bug.

Comment 2

[Chris Waldron]

I was able to narrow down the problem.  In JavaScipt, the assignment to the src
property of an HTMLImageElement causes Mozilla to not refresh the Progress Bar.
 This is the observable behavior as I have no idea what is happening internally.

I am also assuming that using the src property in JavaScript is how images are
assigned to image elements unless there is another (perhaps) more standard way.
 IE uses the src property and I presume Mozilla 1.6 (as this works on that version).

Repro to be attach...

Thanks,
ChrisWa.

Comment 3

[Chris Waldron]

Attachment: Mozbug page source

Enclosed is the page source for the mozilla bug causes when an assignment is
made via the src property of an HTMLImageElement

Comment 4

[Chris Waldron]

Attachment: Accompanying image

Here's an image that you can use.  The image is merely a white background
placeholder.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Which exact progress bar are we talking about?  What should I be looking for
after I load the "Mozbug page source" attachment?

Comment 6

[Chris Waldron]

I thought the commentary was self explanatory and have you run the repro?

When you run the repro you'll see the following...

[1]The progress bar does not refresh.  
[2]The progress bar does not return to its normal state.
[3]The progress bar remain fully extended.

This is caused by the assignment in JavaScript to the src property of an
HTMLImageElement.  It happens consistently.

I really need a solution very soon as we are about to ship and would hate to
have to tell users to stick with IE.

Thanks,
ChrisWa.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: testcase

This is the testcase in directly usable form

So is the problem the _browser's_ progress bar, that still shows "Transferring
data from ..." even though the page seems to be complete?

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #7)
> So is the problem the _browser's_ progress bar, that still shows "Transferring
> data from ..." even though the page seems to be complete?

er, "status bar".

The progress bar does hide for me...

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

bug 250542 sounds like a duplicate of this bug

Comment 10

[Boris Zbarsky [:bzbarsky]]

> I thought the commentary was self explanatory

It wasn't.

> and have you run the repro?

Yes, of course.  No need to be insulting, now.

What should I be looking at when I do?  The browser progress bar?  Or something
in the page that you're calling a progress bar?

Note that the browser progress bar had some updating issues in 1.6 (and maybe in
1.7; I can't recall when darin fixed them exactly).

Comment 11

[Chris Waldron]

Boris

  I do apologize if I offended you.  Your response surprised me.  What occurs is
that the *browser's* proress bar fails to return back to its normal state after
the page loads should you make an assignment to an HTMLImageElement src property.

  This works normally in 1.6.  The image is a 9x13 white background JPEG.  I
don't know if that could be causing any problems

Thanks,
Chris

  

Comment 12

[Boris Zbarsky [:bzbarsky]]

Chris, thank you for the clarification.  I think we're all on the same
wavelength now.  Confirming bug.  I would bet that the problem is that something
picks up the progress notification from the image (since it thinks overall page
progress is affected) and ignores the STATE_STOP from the image (since the image
is not the main page).

I'd say once onload has fired we should no longer be looking at progress
notifications...

I'm not really sure where this progress stuff belongs, but let's try xpfe, since
all the necko/docshell folks are cced already.  Neil, jag, any ideas where we
should poke at?

Comment 13

[Darin Fisher]

bz: nsBrowserStatusHandler.js ?

Comment 14

[[e-mail]]

nsBrowserStatusFilter.cpp might be a good place to exclude notifications.

Comment 15

[J.O.]

*** Bug 261736 has been marked as a duplicate of this bug. ***

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

*** This bug has been marked as a duplicate of 209330 ***