248810 - nsIStreamConverter[Service] uses wide strings for mime types

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsIStreamConverter and nsIStreamConverterService use wide strings for mime
types. that's completely unnecessary, and a waste of codesize due to conversions
PRUnichar<->char

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Brodie]

Would this...

Index: netwerk/streamconv/src/nsStreamConverterService.cpp
     nsCAutoString contractID(NS_ISTREAMCONVERTER_KEY);
     contractID.Append("?from=");
     contractID.Append(aFromType);
     contractID.Append("&to=");
     contractID.Append(aToType);

(x 2) be more efficient as a single assign?

 nsCAutoString contractID(
  NS_LITERAL_CSTRING(NS_ISTREAMCONVERTER_KEY) +
  NS_LITERAL_CSTRING("?from=") +
  nsDependentCString(aFromType) +
  NS_LITERAL_CSTRING("&to=") +
  nsDependentString(aToType) );

Or at least using AppendLiteral for the 2 literals.

Comment 3

[Darin Fisher]

Comment on attachment 151809 [details] [diff] [review]
patch

need to rev UUID on interfaces, and please move NS_STREAMCONVERTERSERVICE_CID
into nsNetCID.h ... no CID or ContractID should be declared in an interface
(general rule of thumb).

probably makes sense to keep NS_ISTREAMCONVERTER_KEY in the IDL file though.

i agree with brodie.. maybe do a dependent concat.

r+sr=darin with those changes.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

hm... ok... I'll make a concat, but I wonder if the cost of the three
constructors & destructors (of the literal strings) is worth it, performance-
and codesize-wise.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

(add two ctors/dtors to the list - nsDependentCString)

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 7

[Darin Fisher]

(In reply to comment #4)
> hm... ok... I'll make a concat, but I wonder if the cost of the three
> constructors & destructors (of the literal strings) is worth it, performance-
> and codesize-wise.

good point... though ctors are inlined