Closed
Bug 24890
Opened 25 years ago
Closed 25 years ago
Cannot dismiss sub-dialogs brought up from prefs panel
Categories
(SeaMonkey :: Preferences, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M14
People
(Reporter: waqar, Assigned: bugs)
References
()
Details
(Whiteboard: [pdt-])
*** going to set a boolean pref: false *** just set a boolean pref: false JavaScript Error: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPref.SetBoolPref]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: chrome://pref/content/pref.js :: PREF_ParsePref :: line 135" data: no]
Comment 1•25 years ago
|
||
This must be a "libPref" bug.
Assignee: nobody → neeti
Component: Browser-General → libPref
QA Contact: nobody → sairuh
Changing component to PrefUI
Assignee: neeti → matt
Component: libPref → Pref UI
Can you be more specific? I don't get this error Which version of the browser are you using?
Comment 5•25 years ago
|
||
I was about to make a new bug with the same description. Except the JS error I see is: JavaScript Error: TypeError: elementObject.elType has no properties URL: chrome://pref/content/pref.js LineNo: 157 I have a fresh depend build on NT. And I see this error with and without the big bunch of xpconnect changed I just checked in.
Looks like you changed this line on the 25th. Giving this bug to you.
Assignee: matt → ben
Assignee | ||
Comment 8•25 years ago
|
||
this is my fault. I forgot to check in an update to a file. checking in asap...
Status: NEW → ASSIGNED
Comment 9•25 years ago
|
||
I'm also seeing this in all the viewers that are called up under the preference panel. Namely the cookie viewer, signon viewer, and wallet editor. In those cases neither the OK or the Cancel button work. However if I bring up those same viewers from the menu (tasks/wallet/...), the buttons work fine.
Updated•25 years ago
|
Summary: Pressing ok in the prefs panel give javascript error. → [PP] Pressing ok in the prefs panel give javascript error.
Comment 10•25 years ago
|
||
This is working fine on NT, but not on unix. I haven't tried it on a mac.
Comment 11•25 years ago
|
||
Oops, ignore my comment about linux only. My NT bits are a day old so my comment is invalid.
Summary: [PP] Pressing ok in the prefs panel give javascript error. → Pressing ok in the prefs panel give javascript error.
Assignee | ||
Comment 12•25 years ago
|
||
the error jband sees is a legitimate, PP bug that I KNOW exists because I have the changes required to fix it and the CVS server doesnt ;)
Comment 13•25 years ago
|
||
*** Bug 25184 has been marked as a duplicate of this bug. ***
Comment 14•25 years ago
|
||
*** Bug 25179 has been marked as a duplicate of this bug. ***
Comment 15•25 years ago
|
||
*** Bug 23509 has been marked as a duplicate of this bug. ***
Comment 16•25 years ago
|
||
*** Bug 23918 has been marked as a duplicate of this bug. ***
Comment 17•25 years ago
|
||
In todays build this is working for me.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
Comment 18•25 years ago
|
||
*** Bug 23869 has been marked as a duplicate of this bug. ***
Comment 19•25 years ago
|
||
*** Bug 25815 has been marked as a duplicate of this bug. ***
Comment 20•25 years ago
|
||
*** Bug 25980 has been marked as a duplicate of this bug. ***
Comment 21•25 years ago
|
||
Reopening since sairuh reports that she's still seeing thin on linux (see bug 25980) The OK/Cancel button is working fine for the prefs panel but not for any window that is brough up from the prefs panel -- namel signon viewer, wallet editor, and cookie viewer. Changing Summary line to accurately reflect the remaining problem.
Status: RESOLVED → REOPENED
Keywords: beta1
Resolution: WORKSFORME → ---
Summary: Pressing ok in the prefs panel give javascript error. → Cannot dismissed sub-dialogs brought up from prefs panel
Assignee | ||
Comment 22•25 years ago
|
||
the prefwindow itself is modal, the window spawned is not told explicitly to be modal, but it appears the prefwindow is being modal to the spawned dialog (does that make sense?) such that the prefwindow can receive events, but the window opened from it cannot.
Assignee: ben → danm
Status: REOPENED → NEW
Comment 23•25 years ago
|
||
*** Bug 26358 has been marked as a duplicate of this bug. ***
Comment 24•25 years ago
|
||
sigh. you can't bring up non-modal dialogs from modal ones.
Comment 25•25 years ago
|
||
So can we explicitly request that the subdialogs be modal when we open them? Would that solve the problem?
Comment 26•25 years ago
|
||
Wow. Lots of noise about this bug? Yes, it's a known problem that you can't open a non-modal window from a modal one. It's been that was as long as we've had modal dialogs. That's one of the edge cases that don't work and I may have to fix it some day but for now, all I have to say is, "don't do that." And "do instead as Morse suggests, just above." And "bring me lasagna." But that's all I have to say. Assigning to Ben because he seems as good a JS weenie to pick on as any. Ben, for now, you guys just want to make sure that all subdialogs opened from a modal dialog are themselves modal. PS: I'm surprised this crashes, though. On my machine, it does what you'd expect: the nonmodal window is just dead and nothing as simple as the "cancel" button will get rid of it.
Assignee: danm → ben
Summary: Cannot dismissed sub-dialogs brought up from prefs panel → Cannot dismiss sub-dialogs brought up from prefs panel
Assignee | ||
Comment 27•25 years ago
|
||
I can certainly hack around this for now, providing you'll assure me this will be fixed at some point in the future ;) you know.. if our prefwindow wasn't modal, we wouldn't have this problem ;)
Status: NEW → ASSIGNED
Assignee | ||
Comment 30•25 years ago
|
||
fix checked in. not actually a workaround since I dont see the disadvantage of these dialogs being modal in this case anyway...
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Comment 31•25 years ago
|
||
Bulk move of all Pref UI component bugs to new Preferences component. Pref UI component will be deleted.
Component: Pref UI → Preferences
Comment 32•25 years ago
|
||
verif blocked by bugs 28177 and 28083.
Comment 34•25 years ago
|
||
finally. verif on mac, linux, winNT w/today opt bits 2000225xx.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•