24906 - PR_IsNetAddrType() cleanups

Status: RESOLVED FIXED

(NSPR :: NSPR, enhancement, P3)

Description

[John G. Myers]

Some protocols, such as FTP, will need to know if an address is v4 or v4mapped.

Comment 1

[John G. Myers]

Attachment: proposed patch to add PR_IpAddrV4Mapped

Comment 2

[John G. Myers]

Proposed patch also fixes PR_IsNetAddrType(PR_IpAddrLoopback) to recognized v4
mapped loopback addresses.

Comment 3

[John G. Myers]

Should PR_IsNetAddrType(::FFFF:0, PR_IpAddrAny) return PR_TRUE ?

Comment 4

[John G. Myers]

I'm working on cleaning up PR_IsNetAddrType(), will submit new patch and 
reassign back when done.

Comment 5

[Wan-Teh Chang]

We should check RFC 2553 to see if it has any
guidance on whether ::FFFF:0 should be considered
a wildcard address, and similarly, whether
::FFFF:127.0.0.1 should be considered a loopback
address for IPv6.

Comment 6

[John G. Myers]

Changing summary, was "Need mechanism for determining if addr is v4 or v4mapped"

RFC 2553 is a bit silent on the issue.  I can't help but to think 
::FFFF:127.0.0.1 must be considered a loopback address, as that is what NSPR 
will generate in some cases.
 

Comment 7

[John G. Myers]

Attachment: Updated proposed fix

Comment 8

[John G. Myers]

Latest proposed fix also extends PR_IpAddrLoopback to match any v4 address in
net 127.

Comment 9

[John G. Myers]

Reassign to Srinivas for review.

Comment 10

[John G. Myers]

I misspelled IN6_IS_ADDR_UNSPECIFIED in the 1/25/00 patch by leaving out an F.

Comment 11

[srinivas]

Checked in the modifications, but for the following:

- recognize Ipv4 addresses as Ipv4-mapped addresses
- PR_IpAddrLoopback to match any v4 address in net 127

These modifications don't seem correct.


/cvsroot/mozilla/nsprpub/pr/src/misc/prnetdb.c, new revision: 3.11.4.6
/cvsroot/mozilla/nsprpub/pr/tests/gethost.c, new revision: 3.1.18.3

Comment 12

[John G. Myers]

Good enough, I think you can resolve this fixed.

You probably should remove the extern declaration of ConvertToIpv4NetAddr() in 
prnetdb.c as it is no longer referenced.

Comment 13

[srinivas]

Markingfixed.

Comment 14

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/56e259db5879
[fenix] For https://github.com/mozilla-mobile/fenix/issues/24906: Add SURVEY style to nimbus messages FML.