249337 - Unread count is > 0, but nothing displays in the messages pane

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jon Baumgartner]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040628 Firefox/0.9.1
Build Identifier: Thunderbird version 0.7+ (20040629) on OS X 10.3.4

See attachment. I have "Unread" selected as the filter for view. Thunderbird
shows the Junk folder in bold, indicating there is (1) unread message. When I
click on the folder, nothing appears on the right.

If I choose "All" the message appears, and if I then select "Unread" again, the
message also appears.

Reproducible: Sometimes
Steps to Reproduce:
1. Receive new mail.
2. See which folders are bold.
3. Click on the folder(s).

Actual Results:  
Sometimes the above behavior occurs. Sometimes the messages are properly
displayed. In all cases, after switching the view around, it works.

Expected Results:  
The messages should be immediately visible.

Comment 1

[Jon Baumgartner]

Attachment: screenshot demonstrating problem

Comment 2

[Scott MacGregor]

I think my new quick search box may have broken mail views. 

Comment 3

[Jon Baumgartner]

It definitely started happening with very recent builds.

Also, I just noticed that if I leave it on "All" I don't see this behavior.

Comment 4

[Scott MacGregor]

Attachment: possible fix

Comment 5

[Scott MacGregor]

I just checked this possible fix in. It makes us more agressive than I'd like
when it comes to refreshing the quick search view but it does fix the bug. 

Comment 6

[Jon Baumgartner]

I haven't had time to test this in the debug build yet, but I just tested this
on the 20040701 Windows build, and there's no change. Did it not make it in to
the build? Should I re-test tomorrow with the 20040702 build?

Comment 7

[Jon Baumgartner]

Still broken with the version 0.7+ (20040702) build.

Comment 8

[Jon Baumgartner]

Scott, you said you checked this in, but the recent binaries still have this
problem. Is this only fixed with the patch?

Comment 9

[Aaron Zabudsky]

This still happens to me as well on Thunderbird version 0.7+ (20040807) under
Windows XP Professional Service Pack 2.

After some hunting, the problem appears to be in searchBar.js, specifically the
code blocks:

491 function onSearchInput(returnKeyHit)
492 {
493   if (gSearchInput.showingSearchCriteria)
494     return;

535 function Search(str)
536 {
537   if (gSearchInput.showingSearchCriteria)
538     return;

The problem is that the folder listener calls Search("") when a folder is
selected by the user and by default, the search bar is set to show the search
criteria hint text. In this case the if statements above cause the search to be
aborted.

I was able to fix it by editing the lines to read:

493   if (gSearchInput.showingSearchCriteria && !(returnKeyHit &&
gSearchInput.value == "") )

537   if (gSearchInput.showingSearchCriteria && str != "")

Comment 10

[Scott MacGregor]

Attachment: the fix

this suggested fix works for me. Hopefully it won't break anything since this
code sure seems to be awfully fragile.