249410 - No login to mail server if first time password fails

Status: RESOLVED DUPLICATE of bug 160425

(MailNews Core :: Networking: POP, defect)

Description

[wongkokwai]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040614 Firefox/0.9

If password is entered wrongly the first time, and the password dialog appears
for entering again, either correct or wrong password is entered, there is no
connection attempt to mail server. The password dialog just disappears. Must
press the "Get Mail" button again and enter password again.

Reproducible: Always
Steps to Reproduce:
1. Starts Thunderbird
2. when password dialog appears, enter an invlid password
3. Password mismatch alert dialog appears, press ok button
4. when password dialog appears, enter correct password (or even wrong password)
5. password dialog disappears but no login attempt to mail server at all
Actual Results:  
Nothing. To login, need to press the "Get Mail" button again and retry login

Expected Results:  
Send the password to mail server and re-login. If password is mismatched, show
alert dialog. If password is correct, download emails if any

Comment 1

[Christian Eyrich]

Yes, that's how it works as long I know it.
I guess the current behaviour comes from fix of bug 61171, but really can't say
if it's intended. Some comments as well as some code look contradictory to me.
See nsPop3Protocol.cpp, cases for POP3_READ_PASSWORD and POP3_ERROR_DONE.

Comment 2

[Christian Eyrich]

(In reply to comment #1)
> Yes, that's how it works as long I know it.

After some more testing I must take this back. Mozilla/TB does make new login
attempts until the password is ok or the user cancels the PW dialog *or* the
server disconnects.
The last one is what all the real servers I'm using do. And then it looks like
what you described. With an own POP-server-simulating-script that doesn't
disconnect, the cycle goes until the user enters the right PW or cancels.

To verify if that's also what your server does, you'd need to log the connection
with an external packet sniffer.

What could be changed in our code is, that a dropped connection is detected
right after it happened. This would prevend the PW input dialoge to appear after
the wrong password alert. But the user would still be surprised why Mozilla
doesn't ask for a new password.

Comment 3

[Aleksey Nogin]

This also happens with IMAP

Comment 4

[Aleksey Nogin]

The

*** This bug has been marked as a duplicate of 160425 ***