Closed Bug 249580 Opened 20 years ago Closed 16 years ago

Remove unused thunderbird.js prefs

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3

People

(Reporter: stdowa+bugzilla, Assigned: philor)

Details

Attachments

(1 file, 1 obsolete file)

Fix v.1
3.53 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 

    
  
QA Contact: preferences

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix v.1
        — 
          — Splinter Review
      

    


  
Well, not exactly those anymore, but some for sure.

We haven't been overriding general.startup.* since bug 224574 moved them out of all.js; they only have an effect in xpfe/components/startup/, so they haven't mattered in forever.

browser.chrome.site_icons and browser.chrome.favicons are indeed pointless, since we're using tabmail.xml instead of tabbrowser

The wallet prefs are indeed mostly pointless, but we might as well let the switch to toolkit's pwmgr kill them all at once.

autoupdate.enabled is the pref for modules/softupdt/, which probably doesn't even compile, since it hasn't really been touched since 1999.

browser.editor.disabled is a puzzler - unless something went out of its way to read it in three separate pieces, so neither "browser.editor" nor "editor.disabled" appear in the source, it's been present and unused since m10. Whatever it was supposed to be, everyone else has given up on setting it.
Assignee: mscott → philringnalda

        Attachment #152196 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #320496 -
        Flags: review?(mkmelin+mozilla)

    
  
Flags: in-testsuite-
Target Milestone: --- → Thunderbird 3
Version: unspecified → Trunk

    
    

    
  
Comment on attachment 320496 [details] [diff] [review]
Fix v.1

Yup. Looks good, Phil!
r=mkmelin

        Attachment #320496 -
        Flags: review?(mkmelin+mozilla) → review+

    
    

    
  
mail/app/profile/all-thunderbird.js 1.115
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: