Closed Bug 249875 Opened 22 years ago Closed 21 years ago

buglist does not pass w3c validation

Categories

(Bugzilla :: Query/Bug List, defect)

2.17.7
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: bugreport, Assigned: annevk)

Details

Attachments

(1 file, 6 obsolete files)

Below are the results of attempting to parse this document with an SGML parser. 1. Line 148, column 13: element "NOBR" undefined <td><nobr>nor</nobr> You have used the element named above in your document, but the document type you are using does not define an element of that name. This error is often caused by incorrect use of the "Strict" document type with a document that uses frames (e.g. you must use the "Frameset" document type to get the "<frameset>" element), or by using vendor proprietary extensions such as "<spacer>" or "<marquee>" (this is usually fixed by using CSS to achieve the desired effect instead). &#9993; 2. Line 150, column 13: element "NOBR" undefined <td><nobr>P2</nobr> &#9993; 3. Line 152, column 13: element "NOBR" undefined <td><nobr>PC</nobr> &#9993; 4. Line 154, column 13: element "NOBR" undefined <td><nobr>bugreport&#64;bugzilla.net</nobr> &#9993; 5. Line 156, column 13: element "NOBR" undefined <td><nobr>NEW</nobr> &#9993; 6. Line 158, column 13: element "NOBR" undefined <td><nobr></nobr> &#9993; 7. Line 180, column 13: element "NOBR" undefined <td><nobr>nor</nobr> &#9993; 8. Line 182, column 13: element "NOBR" undefined <td><nobr>P2</nobr> &#9993; 9. Line 184, column 13: element "NOBR" undefined <td><nobr>PC</nobr> &#9993; 10. Line 186, column 13: element "NOBR" undefined <td><nobr>bugreport&#64;bugzilla.net</nobr> &#9993; 11. Line 188, column 13: element "NOBR" undefined <td><nobr>NEW</nobr> &#9993; 12. Line 190, column 13: element "NOBR" undefined <td><nobr></nobr> &#9993; 13. Line 212, column 13: element "NOBR" undefined <td><nobr>nor</nobr> &#9993; 14. Line 214, column 13: element "NOBR" undefined <td><nobr>P2</nobr> &#9993; 15. Line 216, column 13: element "NOBR" undefined <td><nobr>PC</nobr> &#9993; 16. Line 218, column 13: element "NOBR" undefined <td><nobr>joel&#64;bugzilla.net</nobr> &#9993; 17. Line 220, column 13: element "NOBR" undefined <td><nobr>NEW</nobr> &#9993; 18. Line 222, column 13: element "NOBR" undefined <td><nobr></nobr> &#9993; 19. Line 290, column 3: end tag for element "P" which is not open </p> The Validator found an end tag for the above element, but that element is not currently open. This is often caused by a leftover end tag from an element that was removed during editing, or by an implicitly closed element (if you have an error related to an element being used where it is not allowed, this is almost certainly the case). In the latter case this error will disappear as soon as you fix the original problem. If this error occured in a script section of your document, you should probably read this FAQ entry. &#9993; Source Listing Below is the source input I used for this validation: 1: <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> 2: <html> 3: <head> 4: <title>Bug List</title> 5: 6: 7: <link rel="Top" href="http://bugzilla.net/tip/"> 8: 9: 10: 11: 12: 13: 14: 15: 16: <link rel="Saved&nbsp;Searches" title="My Bugs" <snip> 19: 20: <link rel="Administration" title="Parameters" 21: href="editparams.cgi"><link rel="Administration" title="Users" 22: href="editusers.cgi"><link rel="Administration" title="Products" 23: href="editproducts.cgi"><link rel="Administration" title="Flag Types" 24: href="editflagtypes.cgi"><link rel="Administration" title="Groups" 25: href="editgroups.cgi"><link rel="Administration" title="Keywords" 26: href="editkeywords.cgi"><link rel="Administration" title="Sanity Check" 27: href="sanitycheck.cgi"> 28: 29: 30: <script type="text/javascript"> 31: <!-- 32: 33: function initHelp() {} 34: // --> 35: </script> 36: 37: <link href="css/global.css" rel="stylesheet" type="text/css"> 38: 39: 40: <link href="css/buglist.css" rel="stylesheet" type="text/css"> 41: 42: </head> 43: 44: 45: 46: <body bgcolor="#ffffff" onload="" 47: id="bugzilla-net-tip"> 48: 49: 50: <div id="banner"> 51: <div class="intro"></div> 52: <p id="banner-name"> 53: <span>This is Bugzilla</span> 54: </p> 55: <p id="banner-version"> 56: <a href="http://www.bugzilla.org/"><span>Bugzilla</span></a> 57: <span>Version 2.17.7</span> 58: </p> 59: <div class="outro"></div> 60: </div> 61: 62: <table border="0" cellspacing="0" width="100%"> 63: <tr> 64: <td valign="top" align="left"> 65: <table border="0" cellpadding="0" cellspacing="2"> 66: <tr> 67: <td valign="top" align="left" nowrap="nowrap"> 68: <font size="+1"><b>Bug List</b></font> 69: </td> 70: </tr> 71: </table> 72: </td> 73: <td valign="middle" align="left">&nbsp;</td> 74: <td valign="middle" align="left"></td> 75: </tr> 76: </table> 77: 78: <div align="center"> 79: <b>Mon Jul 5 10:00:34 PDT 2004</b><br> 80: 81: 82: <a href="quips.cgi"><i>Bugzilla would like to put a random quip here, but no one has entered any.</i></a> 83: 84: </div> 85: 86: 87: <hr> 88: 89: 90: 91: 92: 93: 94: 95: 96: 97: 98: 99: 100: 101: 102: <table class="bz_buglist" cellspacing="0" cellpadding="4" width="100%"> 103: <colgroup> 104: <col class="bz_id_column"> 105: <col class="bz_bug_severity_column"> 106: <col class="bz_priority_column"> 107: <col class="bz_rep_platform_column"> 108: <col class="bz_assigned_to_column"> 109: <col class="bz_bug_status_column"> 110: <col class="bz_resolution_column"> 111: <col class="bz_short_short_desc_column"> 112: </colgroup> 113: <snip> 137: 138: <tr class="bz_normal 139: bz_P2 140: bz_NEW 141: bz_ 142: bz_secure"> 143: 144: <td> 145: <a href="show_bug.cgi?id=1">1</a> 146: </td> 147: 148: <td><nobr>nor</nobr> 149: </td> 150: <td><nobr>P2</nobr> 151: </td> 152: <td><nobr>PC</nobr> <snip> 157: </td> 158: <td><nobr></nobr> 159: </td> 160: <td>is attachment 1 [details] [diff] [review] a problem 161: </td> 162: 163: </tr> 164: 165: 166: 167: 168: 169: 170: <tr class="bz_normal 171: bz_P2 172: bz_NEW 173: bz_ 174: bz_secure"> 175: 176: <td> 177: <a href="show_bug.cgi?id=2">2</a> 178: </td> 179: 180: <td><nobr>nor</nobr> 181: </td> 182: <td><nobr>P2</nobr> 183: </td> 184: <td><nobr>PC</nobr> 185: </td> 186: <td><nobr>bugreport&#64;bugzilla.net</nobr> 187: </td> 188: <td><nobr>NEW</nobr> 189: </td> 190: <td><nobr></nobr> 191: </td> 192: <td>This is a very long description that will require the fie... 193: </td> 194: 195: </tr> 196: 197: 198: 199: 200: 201: 202: <tr class="bz_normal 203: bz_P2 204: bz_NEW 205: bz_ 206: bz_secure"> 207: 208: <td> 209: <a href="show_bug.cgi?id=3">3</a> 210: </td> 211: 212: <td><nobr>nor</nobr> 213: </td> 214: <td><nobr>P2</nobr> 215: </td> 216: <td><nobr>PC</nobr> 217: </td> 218: <td><nobr>joel&#64;bugzilla.net</nobr> 219: </td> 220: <td><nobr>NEW</nobr> 221: </td> 222: <td><nobr></nobr> 223: </td> 224: <td>eftre 225: </td> 226: 227: </tr> 228: 229: 230: </table> 231: 232: 233: 234: 235: 3 bugs found. 236: 237: <br> 238: 239: 240: 241: 242: 243: 244: 245: 246: 247: 248: <p> 249: <table> 250: <tr> 251: <td valign="middle"> 252: <form method="post" action="long_list.cgi"> 253: <input type="hidden" name="buglist" value="1,2,3"> 254: <input type="submit" value="Long Format"> 255: </form> 256: </td> 257: 258: <td>&nbsp;</td> 259: 260: <td valign="middle"> 261: <a href="buglist.cgi?query_format=&amp;short_desc_type=allwordssubstr&amp;short_desc=&amp;long_desc_type=substring&amp;long_desc=&amp;bug_file_loc_type=allwordssubstr&amp;bug_file_loc=&amp;status_whiteboard_type=allwordssubstr&amp;status_whiteboard=&amp;keywords_type=allwords&amp;keywords=&amp;bug_status=NEW&amp;bug_status=ASSIGNED&amp;bug_status=REOPENED&amp;emailassigned_to1=1&amp;emailtype1=substring&amp;email1=&amp;emailassigned_to2=1&amp;emailreporter2=1&amp;emailqa_contact2=1&amp;emailcc2=1&amp;emailtype2=substring&amp;email2=&amp;bugidtype=include&amp;bug_id=&amp;votes=&amp;chfieldfrom=&amp;chfieldto=Now&amp;chfieldvalue=&amp;field0-0-0=noop&amp;type0-0-0=noop&amp;value0-0-0=&amp;Bugzilla_login=k2%40bugzilla.net&amp;Bugzilla_password=apassword&amp;ctype=csv">CSV</a> | 262: <a href="buglist.cgi?query_format=&amp;short_desc_type=allwordssubstr&amp;short_desc=&amp;long_desc_type=substring&amp;long_desc=&amp;bug_file_loc_type=allwordssubstr&amp;bug_file_loc=&amp;status_whiteboard_type=allwordssubstr&amp;status_whiteboard=&amp;keywords_type=allwords&amp;keywords=&amp;bug_status=NEW&amp;bug_status=ASSIGNED&amp;bug_status=REOPENED&amp;emailassigned_to1=1&amp;emailtype1=substring&amp;email1=&amp;emailassigned_to2=1&amp;emailreporter2=1&amp;emailqa_contact2=1&amp;emailcc2=1&amp;emailtype2=substring&amp;email2=&amp;bugidtype=include&amp;bug_id=&amp;votes=&amp;chfieldfrom=&amp;chfieldto=Now&amp;chfieldvalue=&amp;field0-0-0=noop&amp;type0-0-0=noop&amp;value0-0-0=&amp;Bugzilla_login=k2%40bugzilla.net&amp;Bugzilla_password=apassword&amp;ctype=ics">iCalendar</a> | 263: <a href="colchange.cgi?query_format=&amp;short_desc_type=allwordssubstr&amp;short_desc=&amp;long_desc_type=substring&amp;long_desc=&amp;bug_file_loc_type=allwordssubstr&amp;bug_file_loc=&amp;status_whiteboard_type=allwordssubstr&amp;status_whiteboard=&amp;keywords_type=allwords&amp;keywords=&amp;bug_status=NEW&amp;bug_status=ASSIGNED&amp;bug_status=REOPENED&amp;emailassigned_to1=1&amp;emailtype1=substring&amp;email1=&amp;emailassigned_to2=1&amp;emailreporter2=1&amp;emailqa_contact2=1&amp;emailcc2=1&amp;emailtype2=substring&amp;email2=&amp;bugidtype=include&amp;bug_id=&amp;votes=&amp;chfieldfrom=&amp;chfieldto=Now&amp;chfieldvalue=&amp;field0-0-0=noop&amp;type0-0-0=noop&amp;value0-0-0=&amp;Bugzilla_login=k2%40bugzilla.net&amp;Bugzilla_password=apassword">Change&nbsp;Columns</a> | 264: 265: <a href="buglist.cgi?query_format=&amp;short_desc_type=allwordssubstr&amp;short_desc=&amp;long_desc_type=substring&amp;long_desc=&amp;bug_file_loc_type=allwordssubstr&amp;bug_file_loc=&amp;status_whiteboard_type=allwordssubstr&amp;status_whiteboard=&amp;keywords_type=allwords&amp;keywords=&amp;bug_status=NEW&amp;bug_status=ASSIGNED&amp;bug_status=REOPENED&amp;emailassigned_to1=1&amp;emailtype1=substring&amp;email1=&amp;emailassigned_to2=1&amp;emailreporter2=1&amp;emailqa_contact2=1&amp;emailcc2=1&amp;emailtype2=substring&amp;email2=&amp;bugidtype=include&amp;bug_id=&amp;votes=&amp;chfieldfrom=&amp;chfieldto=Now&amp;chfieldvalue=&amp;field0-0-0=noop&amp;type0-0-0=noop&amp;value0-0-0=&amp;Bugzilla_login=k2%40bugzilla.net&amp;Bugzilla_password=apassword&amp;order=bugs.bug_status%2C%20bugs.priority%2C%20map_assigned_to.login_name%2C%20bugs.bug_id&amp;tweak=1" 266: >Change&nbsp;Several&nbsp;Bugs&nbsp;at&nbsp;Once</a> 267: | 268: 269: <a href="mailto:bugreport&#64;bugzilla.net,joel&#64;bugzilla.net">Send&nbsp;Mail&nbsp;to&nbsp;Bug&nbsp;Owners</a> | 270: </td> 271: 272: <td valign="middle"> 273: <a href="query.cgi?query_format=&amp;short_desc_type=allwordssubstr&amp;short_desc=&amp;long_desc_type=substring&amp;long_desc=&amp;bug_file_loc_type=allwordssubstr&amp;bug_file_loc=&amp;status_whiteboard_type=allwordssubstr&amp;status_whiteboard=&amp;keywords_type=allwords&amp;keywords=&amp;bug_status=NEW&amp;bug_status=ASSIGNED&amp;bug_status=REOPENED&amp;emailassigned_to1=1&amp;emailtype1=substring&amp;email1=&amp;emailassigned_to2=1&amp;emailreporter2=1&amp;emailqa_contact2=1&amp;emailcc2=1&amp;emailtype2=substring&amp;email2=&amp;bugidtype=include&amp;bug_id=&amp;votes=&amp;chfieldfrom=&amp;chfieldto=Now&amp;chfieldvalue=&amp;field0-0-0=noop&amp;type0-0-0=noop&amp;value0-0-0=&amp;Bugzilla_login=k2%40bugzilla.net&amp;Bugzilla_password=apassword">Edit&nbsp;Search</a> 274: </td> 275: 276: <td>&nbsp;</td> 277: 278: <td valign="middle"> 279: <form method="get" action="buglist.cgi"> 280: <input type="submit" value="Remember search"> as 281: <input type="hidden" name="newquery" 282: value="query_format=&amp;short_desc_type=allwordssubstr&amp;short_desc=&amp;long_desc_type=substring&amp;long_desc=&amp;bug_file_loc_type=allwordssubstr&amp;bug_file_loc=&amp;status_whiteboard_type=allwordssubstr&amp;status_whiteboard=&amp;keywords_type=allwords&amp;keywords=&amp;bug_status=NEW&amp;bug_status=ASSIGNED&amp;bug_status=REOPENED&amp;emailassigned_to1=1&amp;emailtype1=substring&amp;email1=&amp;emailassigned_to2=1&amp;emailreporter2=1&amp;emailqa_contact2=1&amp;emailcc2=1&amp;emailtype2=substring&amp;email2=&amp;bugidtype=include&amp;bug_id=&amp;votes=&amp;chfieldfrom=&amp;chfieldto=Now&amp;chfieldvalue=&amp;field0-0-0=noop&amp;type0-0-0=noop&amp;value0-0-0=&amp;Bugzilla_login=k2%40bugzilla.net&amp;Bugzilla_password=apassword"> 283: <input type="hidden" name="cmdtype" value="doit"> 284: <input type="hidden" name="remtype" value="asnamed"> 285: <input type="text" name="newqueryname" size="20"> 286: </form> 287: </td> 288: </tr> 289: </table> 290: </p> 291: 292: 293: 294: 295: 296: <div id="footer"> 297: <div class="intro"></div> 298: 299: 300: 301: 302: <form method="get" action="show_bug.cgi"> 303: <div id="useful-links"> 304: <div id="links-actions"> 305: <div class="label">Actions:</div> 306: <div class="links"> 307: <a href="enter_bug.cgi">New</a> | 308: <a href="query.cgi">Search</a> | 309: 310: <input class="btn" type="submit" value="Find"> bug # 311: <input class="txt" name="id" size="6"> | 312: 313: <a href="report.cgi">Reports</a> 314: 315: | <a href="request.cgi?requester=k2%40bugzilla.net&amp;requestee=k2%40bugzilla.net&amp;do_union=1&amp;group=type">My Requests</a> 316: 317: | <a href="votes.cgi?action=show_user">My&nbsp;Votes</a> 318: | <a href="sanitycheck.cgi">Sanity&nbsp;check</a> 319: | <a href="relogin.cgi">Log&nbsp;out</a>&nbsp;k2&#64;bugzilla.net 320: </div> 321: </div> 322: 323: <div id="links-edit"> 324: <div class="label">Edit:</div> 325: <div class="links"> 326: 327: <a href="userprefs.cgi">Prefs</a> | <a href="editparams.cgi">Parameters</a> | <a href="editusers.cgi">Users</a> | <a href="editproducts.cgi">Products</a> | <a href="editflagtypes.cgi">Flags</a> | <a href="editgroups.cgi">Groups</a> | <a href="editkeywords.cgi">Keywords</a> 328: </div> 329: </div> 330: 331: 332: 333: 334: <div id="links-saved"> 335: <div class="label"> 336: Saved&nbsp;Searches: 337: </div> 338: <div class="links"> 339: <a href="buglist.cgi?bug_status=NEW&amp;bug_status=ASSIGNED&amp;bug_status=REOPENED&amp;email1=k2%40bugzilla.net&amp;emailtype1=exact&amp;emailassigned_to1=1&amp;emailreporter1=1">My&nbsp;Bugs</a> 340: 341: </div> 342: </div> 343: </div> 344: </form> 345: 346: <div class="outro"></div> 347: </div> 348: 349: </body> 350: </html>
This appears to be on purpose, the decision involving this was made on bug 150770. The footer is affected as well, not just the buglist columns. Both were changed in that bug. Since the idea was to violate the HTML spec in order to work around a CSS bug in IE 5.5, and that bug was fixed in IE 6.0, my current take on this is that we should go ahead and shoot for the HTML compliance again, and use CSS to do this the right way. The browsers that it works in will get pretty buglists, and the ones it doesn't (IE 5.5) will get wordwrapped cells. So what? :) The data is still readable, it just doesn't look quite as pretty. It's not dataloss, it's only presentation. I won't hold RC for this, but it should be in before 2.18 final release.
Flags: blocking2.18+
Target Milestone: --- → Bugzilla 2.18
CCing the people who assisted in making that decision on the other bug... input please?
Seems fair enough to me. Gerv
Attached patch use css (obsolete) — Splinter Review
Assignee: justdave → bugreport
Status: NEW → ASSIGNED
Attachment #154176 - Flags: review?
Comment on attachment 154176 [details] [diff] [review] use css >-<p> >+<br> > <table> > <tr> > [% IF bugs.size > 0 %] >@@ -191,7 +191,6 @@ > [% END %] > </tr> > </table> >-</p> Can't we use the 'margin' property? Instead of using this useless BR element? >+ <td [% 'class="nowrap"' IF NOT abbrev.$column.wrap %]> Maybe someone can come up with a better classname?[1] [1]<http://tantek.com/log/2004/07.html#d20t2359>
Attachment #154176 - Flags: review?
Attached patch v2 (obsolete) — Splinter Review
This also fixes the change-multiple except for the wrap=hard (which must stay until the line-wrapping policy is fixed)
Attachment #154176 - Attachment is obsolete: true
Attachment #154187 - Flags: review?
Comment on attachment 154187 [details] [diff] [review] v2 >Index: css/buglist.css I'd rather we not added a class for nowrap here (unless there's a real style that we want to apply consistently to that certain bit of content, in which case we should give it an understandable name <wink>). Instead, use a local style. template/en/default/list/edit-multiple.html.tmpl >-<p><font size="-1"> >+<div style="{ font-size: smaller; }"> Could this style be applied to the <p> here and avoid the div? p has some margin foo that div lacks. >Index: template/en/default/list/list.html.tmpl >- [% '<nobr>' IF NOT abbrev.$column.wrap %] >+ <td [% 'class="buglist_std"' IF NOT abbrev.$column.wrap %]> Just make this a style="white-space: nowrap" and r=kiko
Attachment #154187 - Flags: review? → review-
Actually, the <p> will get closed out automatically by the list, so the list would return to the larger size. We could use a <p> within a <div> if that helps??
OK, per a discussion with Joel on IRC, I'm going to be taking the validation bugs. I like this stuff, anyway. :-D
Assignee: bugreport → mkanat
Status: ASSIGNED → NEW
This one has an almost-finished patch, I urge people not to drop this :-/
Whiteboard: not a blocker?
I have to admit that I'm actually to busy to even take a look at this, now. I'm working from 10 AM - 7 PM, and then running around like a madman taking care of other things in the evening.
Assignee: mkanat → bugreport
I'll still take this on the 2.18 branch later, but it's not important enough to block the release
Flags: blocking2.18+ → blocking2.18-
Note that you can now use "FILTER no_break" to prevent line breaks.
Attached patch patch that addresses comments (obsolete) — Splinter Review
We should really move all the STYLE attributes to a style sheet. However, that probably requires some more thought on this. I will try to look into some other validation issues as well when I find them.
Attachment #154187 - Attachment is obsolete: true
Assignee: bugreport → bug
Status: NEW → ASSIGNED
Attachment #172865 - Flags: review?(kiko)
Attached patch patch that addresses comments #2 (obsolete) — Splinter Review
Now "Additional Comments:" is both bold and works.
Attachment #172865 - Attachment is obsolete: true
Attachment #172867 - Flags: review?(kiko)
Attachment #172865 - Flags: review?(kiko)
Attachment #172867 - Flags: review?(kiko) → review?(LpSolit)
Comment on attachment 172867 [details] [diff] [review] patch that addresses comments #2 >-<script type="text/javascript" language="JavaScript"> >+<script type="text/javascript"> Nit: I'm not sure myk would be happy with that. But it's ok for me. >-<label for="comment"><b>Additional Comments:</b></label><br> >+<b><label for="comment">Additional Comments:</label></b><br> > <textarea id="comment" name="comment" rows="5" cols="80" wrap="hard"></textarea><br> Nit: Note that wrap="hard" does not exist anymore (which is the reason why this patch is bitrotten). There are still some problems in edit-multiple.html.tmpl, lines 195-198: we have <th></td> stuff instead of <th></th>. Please do not remove the end tags, as discussed on IRC.
Attachment #172867 - Flags: review?(LpSolit) → review-
Attached patch patch #2 (obsolete) — Splinter Review
Attachment #172867 - Attachment is obsolete: true
Attachment #174401 - Flags: review?(LpSolit)
Attached patch patch #4 (obsolete) — Splinter Review
Attachment #174401 - Attachment is obsolete: true
Attachment #174403 - Flags: review?(LpSolit)
Comment on attachment 174403 [details] [diff] [review] patch #4 >-<p><font size="-1"> >- To change multiple [% terms.bugs %]: >- <ol> >+<p style="font-size:smaller"> >+ To change multiple [% terms.bugs %]:</p> >+ <ol style="font-size:smaller"> > <li>Check the [% terms.bugs %] you want to change above.</li> > <li>Make your changes in the form fields below. If the change > you are making requires an explanation, include it in > the comments box.</li> > <li>Click the <em>Commit</em> button.</li> > </ol> >-</font></p> Nit: you should write: <p style="font-size:smaller"> To change multiple [% terms.bugs %]: </p> <ol style="font-size:smaller"> <li>Check the [% terms.bugs %] you want to change above.</li> <li>Make your changes in the form fields below. If the change you are making requires an explanation, include it in the comments box.</li> <li>Click the <em>Commit</em> button.</li> </ol> I would be happy to see a new patch with this nit corrected. Either set r+ yourself on the new patch (if you don't change anything else) or ask me again. r=LpSolit
Attachment #174403 - Flags: review?(LpSolit) → review+
Attachment #174401 - Flags: review?(LpSolit)
This bug is targetted 2.18 so requesting approval for both.
Flags: approval?
Flags: approval2.18?
This doesn't seem significant enough to go into a 2.18 branch.
Flags: approval?
Flags: approval2.18?
Flags: approval2.18-
Flags: approval+
Target Milestone: Bugzilla 2.18 → Bugzilla 2.20
Comment on attachment 174403 [details] [diff] [review] patch #4 OK, based on the comments in this bug, and on a review of the interdiff, I will check in the "other indentation" patch, below this one.
Attachment #174403 - Attachment is obsolete: true
In the future, when you do the CVS diff, do it from inside the mozilla/webtools/bugzilla directory -- that makes life much easier for applying patches (Otherwise I have to figure out to use -p3). :-) Checking in template/en/default/list/edit-multiple.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v <-- edit-multiple.html.tmpl new revision: 1.24; previous revision: 1.23 done Checking in template/en/default/list/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v <-- list.html.tmpl new revision: 1.31; previous revision: 1.30 done Checking in template/en/default/list/table.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/table.html.tmpl,v <-- table.html.tmpl new revision: 1.24; previous revision: 1.23 done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: not a blocker?
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: