249923 - Code size reduction / speed up of nsViewManager class

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[jim_nance]

A little more work in nsViewManager.cpp:

I removed the nsHashtable from the nsViewManager class.  It was only used by two
methods, both of which were called from a common parent.  I create the hash
table on the stack now, and pass it down to the functions that use it.

I removed the method DestroyZTreeNode().  It was only called from
ReparentViews() and all it did was to remove nodes from the hash table.  I do
not think it is necessary to remove these nodes.  They will all die anyway when
ReparentViews returns and the hash is destroyed.  However, I am not that
familiar with this code, and would appreciate feedback on this.

tricia> size old/nsViewManager.o nsViewManager.o
   text    data     bss     dec     hex filename
  32691     396      20   33107    8153 old/nsViewManager.o
  32363     396      20   32779    800b nsViewManager.o

It is definitly smaller and probably faster too.

Comment 1

[jim_nance]

Attachment: Patch to remove hashtable from class, and to remove DestroyZTreeNode

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 152364 [details] [diff] [review]
Patch to remove hashtable from class, and to remove DestroyZTreeNode

cool

Comment 3

[jim_nance]

Code is checked in.  Hopefully this will go better than the last one :-)