Accesskeys for the submenu of "View, Sidebar" are active, however not underlined.

RESOLVED FIXED

Status

()

Firefox
Menus
P5
normal
RESOLVED FIXED
14 years ago
11 years ago

People

(Reporter: Aaron Graves, Assigned: Jesse Ruderman)

Tracking

({fixed-aviary1.0})

unspecified
x86
Windows XP
fixed-aviary1.0
Points:
---
Bug Flags:
blocking-aviary1.0PR +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

14 years ago
Click on view, and go to Sidebar (or press Alt+V+E). Notice how the two items,
Bookmarks and History have no accesskeys underlined (as do the rest of the
menus). However, pressing B (or Alt+V+E+B) or H (or Alt+V+E+H) will activate the
respective menu item. So the accesskey is active, but not visible.

Comment 1

14 years ago
I confirm your finding while using Firefox 0.9.1 build 20040626 under XP Pro
SP1a here.
(Assignee)

Comment 2

14 years ago
Pressing B activates the Bookmarks menu item even though the menu item doesn't
have an accesskey.  You can see the same thing with items in the bookmarks menu:
pressing the first letter of a menu item highlights it, and if there are no
conflits, activates it.
(Assignee)

Comment 3

14 years ago
The History item also appears in the Go menu, where it has the accesskey "i". 
Should the accesskey in View > Sidebar be the same or should it be "H"?

Comment 4

14 years ago
We should never use a lower case i or l for an accesskey unless there's nothing
else available. Too hard to see the underline. 
http://www.mozilla.org/projects/ui/accessibility/accesskey.html

Actually that idea was taken from Microsoft's guidelines for mnemonics.
(Assignee)

Comment 5

14 years ago
I'll make the accesskey for History 's' in both places.
Assignee: firefox → jruderman
(Assignee)

Comment 6

14 years ago
Created attachment 152466 [details] [diff] [review]
patch

Makes the accesskeys 'B' and 's'.  Also renames "manBookmarksCmd", which opens
bokomark manager in Seamoneky but opens the bookmarks sidebar in Firefox, to
"bookmarksSidebarCmd".

cvs diff -u browser/base/content/browser-menubar.inc
browser/base/content/browser-sets.inc browser/base/locale/browser.dtd
(Assignee)

Updated

14 years ago
Attachment #152466 - Flags: review?(mconnor)
(Assignee)

Updated

14 years ago
Flags: blocking-aviary1.0RC1?

Comment 7

14 years ago
Comment on attachment 152466 [details] [diff] [review]
patch

Why don't you use "H" as accesskey for History? That is not used yet in
View->Sidebar.

>+    <key id="viewBookmarksSidebarKb" key="&bookmarksSidebarCmd.commandkey;" command="viewBookmarksSidebar" modifiers="accel"/>
> #ifdef XP_WIN
>+    <key id="viewBookmarksSidebarKb" key="&bookmarksSidebarWinCmd.commandkey;" command="viewBookmarksSidebar" modifiers="accel"/>
Please give the second key a unique id, like viewBookmarksSidebarWinKb. There
was a complaint in bug 243413 comment 15 and 17 about them being identical.

>+<!ENTITY bookmarksSidebarCmd.accesskey  "B">
>+<!ENTITY bookmarksSidebarCmd.commandkey "b">
>+<!ENTITY bookmarksSidebarWinCmd.commandkey "i">
>+<!ENTITY historyCmd.accesskey           "s">
>+<!ENTITY history.commandKey             "h">
You should give the history keys similar names, like
historySidebarCmd.accesskey, historySidebarCmd.commandKey.
(Assignee)

Comment 8

14 years ago
Comment on attachment 152466 [details] [diff] [review]
patch

I don't use H as an accesskey for History because the History item appears in
both Go and in View > Sidebar.	In Go, H is Home.  I could make History use
different accesskeys in different menus... do you think that would be better?

I'll fix the other things you mentioned.
Attachment #152466 - Attachment is obsolete: true
Attachment #152466 - Flags: review?(mconnor)

Comment 9

14 years ago
I see, and you wrote that already in comment 3. My bad.
While I think underlining the "H" in the View menu would look nicer, having
consistent keys is probably better.
(Assignee)

Comment 10

14 years ago
Created attachment 153069 [details] [diff] [review]
patch for trunk

Makes the improvements Steffen suggested in addition to fixing the bug.
(Assignee)

Updated

14 years ago
Attachment #153069 - Flags: review?(mconnor)

Updated

14 years ago
Attachment #153069 - Flags: review?(mconnor) → review+

Updated

13 years ago
Flags: blocking-aviary1.0RC1? → blocking-aviary1.0RC1+
Priority: -- → P5
(Assignee)

Comment 11

13 years ago
Fixed trunk and branch.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: fixed-aviary1.0

Updated

13 years ago
Keywords: fixed-aviary1.0
Whiteboard: fixed-aviary1.0

Updated

11 years ago
QA Contact: bugzilla → menus
You need to log in before you can comment on or make changes to this bug.