Closed
Bug 250080
Opened 20 years ago
Closed 20 years ago
Blank regexp in editgroups can cause all users to be members
Categories
(Bugzilla :: User Accounts, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: bugreport, Assigned: bugreport)
Details
Attachments
(1 file)
|
653 bytes,
patch
|
erik
:
review+
justdave
:
review+
|
Details | Diff | Splinter Review |
Bug 240325 added a regression. When editgroups uses a blank regexp, all users will match.
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.18
|
|
Assignee | |
Comment 1•20 years ago
|
||
The problem only exists in editgroups The rest of the places that try this select only groups that have non-empty regexps.
|
|
Assignee | |
Updated•20 years ago
|
Attachment #152451 -
Flags: review?(erik)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 152451 [details] [diff] [review] One-line fix Hooray. My only nit is that the '+' is gratuitous in the match, but that has no effect, so it's just a style thing.
Attachment #152451 -
Flags: review?(erik) → review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 152451 [details] [diff] [review] One-line fix we're close enough to a release that a 2xr is in order
Attachment #152451 -
Flags: review?(justdave)
|
|
Assignee | |
Updated•20 years ago
|
Flags: blocking2.18?
|
||
Comment 4•20 years ago
|
||
Comment on attachment 152451 [details] [diff] [review] One-line fix doh r=justdave
Attachment #152451 -
Flags: review?(justdave)
|
|
||
Updated•20 years ago
|
Flags: blocking2.18?
Flags: blocking2.18+
Flags: approval+
|
|
Assignee | |
Comment 5•20 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•