Closed
Bug 250143
Opened 20 years ago
Closed 17 years ago
Ignore unassigned mouse buttons >= 8 (GTK2 event handler)
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: peterco, Assigned: mwu)
Details
Attachments
(1 file, 3 obsolete files)
1.92 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040704 Firefox/0.9.1 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1 When using a mouse with more than 7 buttons, firefox generates a left mouse button event for buttons >= 8 instead of simply ignoring the originating button press. Could you please include the attached patch to correct this behaviour? I'm using a Logitech mouse (with the evdev mouse driver) which features autoscrolling for buttons 9 and 10; it generates additional wheel button events (4/5). While "scrolling" with these buttons, firefox adds left button events which renders it unusable. Reproducible: Always Steps to Reproduce: 1. With xev (part of XFree86), check that your mouse generates ButtonPress/ButtonRelease events with "button" >= 8. 2. View any webpage. 3. Click any of the mouse buttons generating button events >= 8. Actual Results: Firefox acts as if the left mouse button (button 1) has been pressed, for example marking text on a webpage or executing a hyperlink. Expected Results: Mouse button events >= 8 should simply be ignored.
Assignee: firefox → blizzard
Component: General → GFX: Gtk
Product: Firefox → Browser
QA Contact: firefox.general → ian
Version: unspecified → Trunk
Attachment #152495 -
Flags: superreview?(blizzard)
Attachment #152495 -
Flags: review?(caillon)
Comment 2•20 years ago
|
||
Comment on attachment 152495 [details] [diff] [review] Explicitly handle NS_MOUSE_LEFT_BUTTON_DOWN event Except now eventType will be undefined for anything other than 1 2 or 3 events. You want to set eventType to NS_EVENT_NULL with an early return I think.
Attachment #152495 -
Flags: review?(caillon) → review-
Updated•20 years ago
|
Attachment #152495 -
Flags: superreview?(blizzard)
Does this solve the problem in a correct manner? If I presume correctly, assigning NS_EVENT_NULL to eventType would become redundant in this case.
Comment 4•19 years ago
|
||
This is an automated message, with ID "auto-resolve01". This bug has had no comments for a long time. Statistically, we have found that bug reports that have not been confirmed by a second user after three months are highly unlikely to be the source of a fix to the code. While your input is very important to us, our resources are limited and so we are asking for your help in focussing our efforts. If you can still reproduce this problem in the latest version of the product (see below for how to obtain a copy) or, for feature requests, if it's not present in the latest version and you still believe we should implement it, please visit the URL of this bug (given at the top of this mail) and add a comment to that effect, giving more reproduction information if you have it. If it is not a problem any longer, you need take no action. If this bug is not changed in any way in the next two weeks, it will be automatically resolved. Thank you for your help in this matter. The latest beta releases can be obtained from: Firefox: http://www.mozilla.org/projects/firefox/ Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html Seamonkey: http://www.mozilla.org/projects/seamonkey/
Comment 5•19 years ago
|
||
Nope, this is still a problem in both Mozilla 1.7.11 and Deer Park beta 1 on Fedora development. The scroll buttons on my MX1000 still activate any hyperlinks that might be in their way.
Attachment #153807 -
Attachment is obsolete: true
Would you please reconsider this bug? Events for mice with more than 7 logical buttons are still handled inappropriately in both the current firefox release (v1.5.0.1) and CVS.
Attachment #152495 -
Attachment is obsolete: true
Attachment #212732 -
Flags: review+
Attachment #212732 -
Flags: review+ → review?(caillon)
Updated•17 years ago
|
Assignee: blizzard → nobody
Component: GFX: Gtk → Widget: Gtk
QA Contact: ian → gtk
Assignee | ||
Comment 7•17 years ago
|
||
I have a MX1000 also. :)
Assignee: nobody → michael.wu
Attachment #212732 -
Attachment is obsolete: true
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #273825 -
Flags: superreview?(roc)
Attachment #273825 -
Flags: review?(roc)
Attachment #212732 -
Flags: review?(caillon)
Attachment #273825 -
Flags: superreview?(roc)
Attachment #273825 -
Flags: superreview+
Attachment #273825 -
Flags: review?(roc)
Attachment #273825 -
Flags: review+
Assignee | ||
Comment 8•17 years ago
|
||
Checking in widget/src/gtk2/nsWindow.cpp; /cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v <-- nsWindow.cpp new revision: 1.224; previous revision: 1.223 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Target Milestone: --- → mozilla1.9beta1
You need to log in
before you can comment on or make changes to this bug.
Description
•