250230 - Gmail doesn't load with the July 7th build.

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

(Networking for now, but might this be something else...?)

Build ID: 2004-07-07-07, Windows XP Seamonkey trunk.

Summary: Gmail doesn't load with the July 7th build.

Steps to Reproduce:

1.  Load www.gmail.com
2.  This will redirect to http://gmail.google.com/gmail

Expected Results:

After the 'Loading...' text in red appears, it should redirect to your Gmail account

Actual Results:

It sticks on 'Loading...', but this isn't doing any client-side loading, it's
waiting for a redirect or something on the server-side.

Build 2004-07-05-09 works just fine.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

linux too.

Comment 2

[Greg Onufer]

SunOS, too.  This is not platform-specific.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

<biesi> Error loading URL
https://www.google.com/accounts/CheckCookie?continue=http%3A%2F%2Fgmail.google.com%2Fgmail&service=mail&chtml=LoginDoneHtml
: 804b0002
<biesi> hm...
<biesi> (that's NS_BINDING_ABORTED)
<biesi> WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(EnsureScriptEnvironment())) failed,
file /home/chb/mozilla/docshell/base/nsWebShell.cpp, line 290
<biesi> WARNING: NS_ENSURE_TRUE(aPresContext) failed, file
/home/chb/mozilla/content/html/content/src/nsGenericHTMLElement.cpp, line 1359
<biesi> the webshell one happens twice; the last one ~10 times

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: this would fix it

so, this patch would fix gmail. I have zero idea whether it is correct or the
right thing to do.

aaronl added this as part of Bug 171366

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

-> aaronl

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

-> dom:html, and cc'ing some people who know this code and can maybe comment on
the patch

Comment 7

[Aaron Leventhal]

Comment on attachment 152547 [details] [diff] [review]
this would fix it

Biesi, can you remove the line instead of commenting it out? With that, r=

Comment 8

[Aaron Leventhal]

I think getting rid of the NS_ENSURE_ARG is the right fix because it will now
continue in the call chain to nsGenericElement::HandleDOMEvent, the way it
always did when aPresContext is null.

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 152547 [details] [diff] [review]
this would fix it

sr=jst with that line removed.

Comment 10

[Daniel Veditz [:dveditz]]

Comment on attachment 152547 [details] [diff] [review]
this would fix it

a=dveditz

Comment 11

[Daniel Veditz [:dveditz]]

This should block 1.8a2 -- high profile site.

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 152547 [details] [diff] [review]
this would fix it

a=sspitzer, but I think we should remove that NS_ENSURE_ARG, instead of
commenting it out, based on aaron's comment:

"I think getting rid of the NS_ENSURE_ARG is the right fix"

can you remove it, instead of commenting it out?

Comment 13

[Bill Mason]

*** Bug 250385 has been marked as a duplicate of this bug. ***

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/html/content/src/nsGenericHTMLElement.cpp;
/cvsroot/mozilla/content/html/content/src/nsGenericHTMLElement.cpp,v  <-- 
nsGenericHTMLElement.cpp
new revision: 1.522; previous revision: 1.521
done

Comment 15

[Johnny Stenback (:jst)]

*** Bug 250352 has been marked as a duplicate of this bug. ***

Comment 16

[Bill Mason]

*** Bug 250494 has been marked as a duplicate of this bug. ***

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with build 2004-07-13-08 on Windows XP.

Comment 18

[Simon Paquet [:sipaq]]

*** Bug 251570 has been marked as a duplicate of this bug. ***

Comment 19

[solo turn]

on w2k i get instead of "loading" with the nightly build version:

var testcookie = 'jscookietest=valid';document.cookie = testcookie;if
(document.cookie.indexOf(testcookie) == -1) {top.location =
'/gmail/html/nocookies.html';}document.cookie = testcookie + ';expires=' + new
Date(0).toGMTString();var agt = navigator.userAgent.toLowerCase();if
(agt.indexOf('msie')!= -1 && document.all) {var control = (agt.indexOf('msie 5')
!= -1) ? 'Microsoft.XMLHTTP' : 'Msxml2.XMLHTTP';try {new NULL /script>

but i'm not sure if this is the right one, as help about says:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040711
Firefox/0.9.0+