250263 - uninitialized memory read in xre_main comparing version

Status: NEW

(Toolkit :: Startup and Profile System, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Starting up firefox I see the following valgrind warnings.  I'm guessing version
isn't initialized.  Line 1820 is currently:

  if (!strcmp(version, aAppData->appBuildID)) {

==2726== Conditional jump or move depends on uninitialised value(s)
==2726==    at 0x4001F9FC: strcmp (mac_replace_strmem.c:227)
==2726==    by 0x80574E3: xre_main(int, char**, nsXREAppData const*)
(/builds/dbaron/aviary-1.0/mozilla/toolkit/xre/nsAppRunner.cpp:1820)
==2726==    by 0x805155D: main
(/builds/dbaron/aviary-1.0/mozilla/browser/app/nsBrowserApp.cpp:58)
==2726==    by 0x42015966: __libc_start_main (in /lib/i686/libc-2.3.2.so)
==2726==
==2726== Conditional jump or move depends on uninitialised value(s)
==2726==    at 0x4001FA0D: strcmp (mac_replace_strmem.c:231)
==2726==    by 0x80574E3: xre_main(int, char**, nsXREAppData const*)
(/builds/dbaron/aviary-1.0/mozilla/toolkit/xre/nsAppRunner.cpp:1820)
==2726==    by 0x805155D: main
(/builds/dbaron/aviary-1.0/mozilla/browser/app/nsBrowserApp.cpp:58)
==2726==    by 0x42015966: __libc_start_main (in /lib/i686/libc-2.3.2.so)
==2726==
==2726== Conditional jump or move depends on uninitialised value(s)
==2726==    at 0x80574E9: xre_main(int, char**, nsXREAppData const*)
(/builds/dbaron/aviary-1.0/mozilla/toolkit/xre/nsAppRunner.cpp:1820)
==2726==    by 0x805155D: main
(/builds/dbaron/aviary-1.0/mozilla/browser/app/nsBrowserApp.cpp:58)
==2726==    by 0x42015966: __libc_start_main (in /lib/i686/libc-2.3.2.so)
==2726==    by 0x805149C: (within
/builds/dbaron/aviary-1.0/mozilla/obj-firefox-debug/dist/bin/firefox-bin)

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

It's worth noting this only happened the first time I started using a profile.