250306 - double clicking an account always expands/collapses the first account

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

If you double click the name of an account (that isn't the first one), we end up
toggling the very first account in the folder pane instead of opening/closing
the account you actually double clicked.

cc'ing Stephen. He might be interested in working on this.

Comment 1

[Stephen Walker]

Backing out aaronl's tree.xml checkin fixes this.

Comment 2

[Scott MacGregor]

Nice job on the detective work Stephen.

Comment 3

[[e-mail]]

I can't reproduce this in my trunk build.

Comment 4

[Stephen Walker]

Attachment: Fix

Comment 5

[[e-mail]]

aaron probably didn't notice that aviary doesn't have the fix to bug 130477.

Comment 6

[Stephen Walker]

Comment on attachment 155068 [details] [diff] [review]
Fix

Sync'ing with xpfe would be much better.

Comment 7

[Scott MacGregor]

aaronl, can you take a look at this? This regression in the aviary toolkit was
apparently triggered by your change to the aviary version of tree.xml for Bug
#246063.

Comment 8

[Aaron Leventhal]

I'm not seeing this in Thunderbird 0.93. Do I need to build Thunderbird to see
this bug?

Comment 9

[Scott MacGregor]

I'm not sure what version 0.9.3 is. I wish I were at 0.9.3!

As I said in the bug, this is trunk only since your change for 246063 is trunk only.

You can download it from the latest-trunk directory

Thanks for looking into this. Would be great to get this regression fixed!

Comment 10

[Aaron Leventhal]

(In reply to comment #9)
> I'm not sure what version 0.9.3 is. I wish I were at 0.9.3!
Sorry I meant 0.7.3 (Aviary)

> As I said in the bug, this is trunk only since your change for 246063 is trunk
only.
I read in comment 7 "This regression in the aviary toolkit was
apparently triggered by your change to the aviary version of tree.xml for Bug
#246063."
Aviary != Trunk
Also, Neil said he can't repro on the trunk.

> You can download it from the latest-trunk directory
I'll try it.
 
> Thanks for looking into this. Would be great to get this regression fixed!
Sure, sorry it took so long.

Comment 11

[Aaron Leventhal]

Neil/Stephen,

Are you saying it makes sense to port the fix from bug 130477 to mozilla/toolkit ?

Comment 12

[Aaron Leventhal]

Attachment: Port of Neil's fix for bug 130477. Tested, works.

Could not build, so I could not test.

When I try to build Thunderbird I get
nsBrowserInstance.cpp
c:/moz\mozilla\xpfe\browser\src\nsBrowserInstance.cpp(106) : fatal error C1083:
Cannot open include file: 'nsToolkitCompsCID.h': No such file or directory

Do I need to build it i na separate directory from Firefox?

Comment 13

[Scott MacGregor]

Did you read the build instructions? 

Something sure looks weird, that line in question is #ifdef'ed MOZ_PHOENIX which
means it would only get built if you were building Firefox. The fact that you
are even compiling that lines says something is pretty messed up in your
thunderbird build environment.

Comment 14

[Stephen Walker]

(In reply to comment #11)
> Neil/Stephen,
> 
> Are you saying it makes sense to port the fix from bug 130477 to mozilla/toolkit ?

Right.  If you already have a Firefox trunk and do not have time to build
Thunderbird, you could just test double clicking in the bookmarks manager.

Comment 15

[Aaron Leventhal]

Comment on attachment 157419 [details] [diff] [review]
Port of Neil's fix for bug 130477. Tested, works.

I didn't look through Neil's code to understand it perfectly, but it runs
without JS errors and fixes the problem. Syncing the firefox tree code with
that change seems to work well.

Comment 16

[Aaron Leventhal]

This affect firefox bookmark manager as well.

Comment 17

[Scott MacGregor]

I'm pretty sure Aaron's checkin was trunk only. So minusing for aviary 1.0. If
the original patch to tree.xml ever goes into the aviary branch then we'd plus this.

Comment 18

[Aaron Leventhal]

Checking in tree.xml;
/cvsroot/mozilla/toolkit/content/widgets/tree.xml,v  <--  tree.xml
new revision: 1.9; previous revision: 1.8
done