Closed Bug 250307 Opened 20 years ago Closed 20 years ago

Unifinder table date-time format: show Due Time (+hide today's date), date/time/all-day order

Categories

(Calendar :: Sunbird Only, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gekacheka, Assigned: mostafah)

References

Details

Attachments

(4 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Firefox/0.9.1, 20040701-cal

1. Due TIME not visible in todo listing
  Actual: only date is displayed
  Expect: time displayed, at least for today's items.
    Omit date for items dated sometime today, like mailnews does.

2. "All Day" appears out of place in event listing
  Actual: appears left of date, date appears on right, but all other
    dates appear with date on left and time on right. 
  Expect: All Day appears in place of time.


Reproducible: Always
Steps to Reproduce:
Add method formatDateTime, which formats both date and time in preferred order,
possibly omitting date if today, optionally substituting a string (such as "All
Day") for time.  See comments for more details.

Modify method formatInterval to call formatDateTime so preferred date time
order is used.
Attachment #152577 - Attachment description: ateUtils.js patch: add formatDateTime, call it from formatInterval → DateUtils.js patch: add formatDateTime, call it from formatInterval
Attachment #152577 - Attachment description: DateUtils.js patch: add formatDateTime, call it from formatInterval → dateUtils.js patch: add formatDateTime, call it from formatInterval
adds formatUnifinderToDoDateTime(datetime) which calls formatDateTime(dateTime,
true).

formatDateTime(datetime, true) will include time, and if datetime is today,
will omit date, so easy to see today's times even if narrow column.
Adds formatUnifinderEventDateTime(datetime, isAllDay), which calls
formatDateTime(dateTime, true, /*localized*/ "All Day").

Modifies getCellText to call formatUifinderEventDateTime for start and end
date.

(Requires calendar.properties patch for localized "All Day")
Add localized text for "All Day"

Remove properties no longer used: unifinderAllDayEventDate,
unifinderNormalEventDate.  (date time order is now handled by dateUtils as is
date format and time format, not hardwired into locale.)
Tested on Moz1.7 in en-US, ja-JP, de-AT, es-ES, fr-FR
Tested on FF0.9.1 and SB20040701 in en-US.

Task table with due date column (or start date, or completed date column):
If date is today, shows only time.
If date is not today, shows date and time, date first by default.

Event table with start date and end date columns:
If date is today, shows only time.
If date is not today, shows date and time, date first by default.
If event is all today, shows only "All Day". 
If event is all day not today, shows "All Day" in place of time (after date like
time).

With language packs other than en-US, "All Day" above is replaced with localized
text.

As in comment 1.  Fixed missed case (same times), moved formatDateTime to end
to preserve line numbers.
Attachment #152577 - Attachment is obsolete: true
Suggested patch order:

  dateUtils.js

  unifinderToDo.js
     Due, Start, Completed date columns should show dates including time, 
     and should omit dates from today's due times.

  locale/en-US/calendar.properties
  unifinder.js 
     Event start/stop dates should omit date from today's datetimes.
     All Day should be on same side as time.

  locale/*/calendar.properties
     All Day should be localized when other language pack chosen.
Summary: Unifinder table date-time format issues: Due time (hide today), date/time/all-day order → Unifinder table date-time format: show Due Time (+hide today's date), date/time/all-day order
Blocks: 220075
Checked in. Thanks
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: gurganbl → sunbird
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: