25032 - Migrate POP with emailaddr in username can't read msg contents.

Status: VERIFIED FIXED

(MailNews Core :: Profile Migration, defect, P3)

Description

[laurel]

Using jan24m13 builds on all platforms

When a POP account with username having email address in it is migrated, the
migrated account can get new message headers, but message content is not
displaying.  

Note:  this is a side issue resulting from bug #22450 (verified). Ref: Other bug
relating to this type of username bug # 24569.

1.   Open a POP account in 4.x.
2.   Edit|Prefs|Mail&Newsgroups|Mail Servers.
     Select POP mail server in the list and click Edit.
     In the server info, edit the User Name field to add @foobar.foo to the end
of the username, so it reads <username>@foobar.foo 
     Confirm OK out of prefs.
3.   Migrate the profile to 5.0, go to mail. 
4.   Select the Inbox, get new messages providing proper login password.
     (If there are no new messages to get, send yourself some from this or other
machine/user and get them.)
     Status bar text indicates new message headers were retrieved and those new
headers display in the inbox.
5.   Select a new message.  No message contents display.
6.   Select a previously retrieved message.  No message contents display.
7.   Exit and return, select an inbox message. No message contents display.

Actual result:  user can get messages, but can't read them.

Expected result:  user should be able to read message contents.

Comment 1

[(not reading, please use [e-mail] instead)]

m14 and accepting.

Comment 2

[Phil Peterson]

4.x was tolerant of this user mistake, so mozilla needs to be too. beta1

Comment 3

[leger]

Putting on PDT+ radar for beta1.

Comment 4

[David :Bienvenu]

Hmm, I made some fixes in this area. You might try again with today's build.

Comment 5

[John G. Myers]

This so-called "tolerance" is a big problem in serverland, servers actually want 
'@' characters in userids.

5.0 should ignore "@foobar.foo" in 4.x profiles being migrated, but that doesn't 
mean it should be doing anything with '@' characters in 5.x profiles.

Comment 6

[Andreas Otte]

Yes you can do that, you should be able to put @ in an userid, but make sure you
escape it before putting it in, because it would otherwise mistaken in
urlparsing for the @ that delimits the prehost from the host.

Comment 7

[John G. Myers]

When typing a userid into the account manager, the user should not need to escape 
anything.  The URL parsing and generation code are what need to do all escaping.

I'll test the ability to use '@' in userids later today and file a bug if needed.

Comment 8

[Andreas Otte]

Of course I was talking about the account manager doing the escaping, not the
user himself.

Comment 9

[(not reading, please use [e-mail] instead)]

this appears to be working.  on linux, I migrated a 4.x pop account with
[e-mail] as my username and I was able to get and read my mail.

I think andreas checkins to the url parsing code fixed it.

it was broken when we had mailbox_message://[e-mail]@tintin/Inbox#1
but now we have mailbox_message://sspitzer%40.netscape.com@tintin/Inbox#1 and it
works fine.

the copies and folder prefs are still broken and I'll go look into that now.

Comment 10

[laurel]

OK using:
2000-02-15-09m14 commercial build on NT 4.0
2000-02-15-10m14 mozilla build on linux rh6.0
2000-02-15-09m14 commerical build on mac OS 9.0

Comment 11

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/4b31f1f7b09a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/25032 - Update detekt-baseline file after event.wrapper removal