Closed Bug 2504 Opened 26 years ago Closed 24 years ago

Image elements aren't tab-stopped and don't show focus.

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
mozilla1.0

People

(Reporter: paulmac, Assigned: attinasi)

References

()

Details

(Keywords: access, Whiteboard: [nsbeta3-])

Attachments

(2 files)

Form elements of type "image" need to be tab stopped & they need to have the
cursor changed to a hand when the mouse is over them. The "bug/feature" is that
we're not treating input form elements uniquely. This creates an inconsistent
feel when web browsing.

For instance, go to the bugsplat login page. It's non-intuitive (web-wise) to
click on something when there's not a hand there. IE supports this.

Other similar sites would be the e*trade login site and Netcenter's webmail
login page.
Status: NEW → ASSIGNED
Summary: Form elements don't look like links to the user. → Image elements don't change cursor on mouseover, tab-stop.
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
QA Contact: 4110 → 4137
Reassigning qa contact to cpratt@netscape.com
Eric, can you set a Target Milestone for this one?
Target Milestone: M6
Guessing I won't get this in for M5
*** Bug 4586 has been marked as a duplicate of this bug. ***
Per bug 4586, another test URL is: http://schist/musicblvd.html
Oh well, I was wrong.
Just checked in a fix.
Assignee: pollmann → joki
Status: ASSIGNED → NEW
Summary: Image elements don't change cursor on mouseover, tab-stop. → Image elements aren't tab-stopped.
The cursor changes now, so the only remaining issue is that image inputs are
simply not tab-stopped.  Tom, can you take this?
Moving out to M7
Status: NEW → ASSIGNED
Target Milestone: M7 → M8
Bonus if I still get to this for M7 but I probably won't.
Target Milestone: M8 → M9
Don't need to be holding M8 with this.
Target Milestone: M9 → M12
Moving down list
Target Milestone: M12 → M14
move to M14 (post-beta)
QA Contact update.
Target Milestone: M14 → M17
Moving M17.
Taking a look at this it seems to be very close to working now.  Focus already 
shifts to the image element, though its not visible currently.  I have a small 
fix to make events trigger the image button.
Keywords: nsbeta3
Whiteboard: [fixinhand]
Updating Milestone to M18.
Target Milestone: M17 → M18
Marking nsbeta3+...
Whiteboard: [fixinhand] → [fixinhand][nsbeta3+]
This bug isn't completely fixed after the landing of joki's fixes.  We can't 
spend more time on this pre Netscape 6 ship.

This bug has been marked "future" because the original netscape engineer working 
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way 
-- please attach your concern to the bug for reconsideration, but do not clear 
the nsbeta3- nomination.
Whiteboard: [fixinhand][nsbeta3+] → [nsbeta3-]
Target Milestone: M18 → Future
Updating QA contact.
QA Contact: ckritzer → vladimire
This bug seems to be fixed except for one cosmetical thing: Indication of focus 
on <input type=image>. Need to have some kind of a border to show around the 
image when you tab to it. 
I can fix this on my PC, although I don't know how to provide a patch.

There is a block in html.css:

:link:focus, :visited:focus {
  -moz-outline: 1px dotted WindowText;
}

Just add input[type="image"]:focus to the list.

In passing, I noticed this block:

img[usemap], object[usemap] {
  color: blue;
  -moz-user-focus: normal;
}

You might want an outline for img[usemap]:focus and object[usemap]:focus i.e.

:link:focus, :visited:focus,
img[usemap]:focus, object[usemap]:focus,
input[type="image"]:focus {
  -moz-outline: 1px dotted WindowText;
}
Marc, can you look at the fix to html.css and check it in if this is correct and
it still works?
Assignee: joki → attinasi
Status: ASSIGNED → NEW
Keywords: access
Target Milestone: Future → ---
The form elements are now styled by rules in forms.css, not html.css. I added
the following rule to forms.css and it works fine:

input[type="image"]:focus {
  -moz-outline: 1px dotted WindowText;
}

CC'ing RodS since this is his thang. Rod, can you review the change to forms.css?
Status: NEW → ASSIGNED
Summary: Image elements aren't tab-stopped. → Image elements aren't tab-stopped and don't show focus.
Target Milestone: --- → mozilla1.0
Attached file simple testcase
Looks good to me r=rods
[note that the WindowText is there because we currently have a bug whereby 
the equivalent of -moz-outline-color is not taking the colour from the 'color'
property correctly. This is similar to the border-color bug. Once that is fixed
we should remove the colours in all our -moz-outline declarations.]
sr=buster
Fixed: rule added to forms.css
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I still dont see any indication of the INPUT type="Image" being selected on 
Windows 98 build 2001-01-31-14-MTEST
Reopening
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
There are unfortunately two bugs (don't know their numbers sorry) that may relate.
1. -moz-outline doesn't work on images at all well anyway (try mozilla logo!).
2. forms.css overrides quirks.css so the standard 2px blue border doesn't appear.
I just verified this working. Please check the testcase attached, and if other
sites / test do not work please attach and reopen.
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
Verifying on 
Windows 98 build 2001-02-06-04-Mtrunk
Liunux RedHat build 2001-02-06-08-Mtrunk
Mac OS8.x build 2001-02-06-08-Mtrunk

Status: RESOLVED → VERIFIED
This will need to be readdressed when bug 72703 is fixed.
Component: HTML: Form Submission → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: