250482 - Find Toolbar: User Feedback ("not found" etc.)

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[Ben Basson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.0+

When the Find Toolbar is used to perform a text or link search, no feedback is
given in the statusbar (as per Find As You Type). This should be corrected to
provide useful feedback again... Example:

Text found: "string" (url)
Text not found: "string"
Link found: "string" (url)
Link not found: "string"

Reproducible: Always
Steps to Reproduce:
1. Press CTRL+F, / or '
2. Type a search string that doesn't exist on a page.

Comment 1

[Jesse Ruderman]

Ideas for feedback:
* "Not found"
* "Wrapped"
* "7 matches" (upon highlighting)

Someone mentioned the idea of turning the Find textbox red when there are no
matches.  I like that idea.

Comment 2

[Steffen Wilberg]

*** Bug 250641 has been marked as a duplicate of this bug. ***

Comment 3

[Thomas Rutter]

Sometimes when using the find toolbar, the result takes a while to come back. 
However, with no feedback in the status bar there is no way of telling if the
find as you type is still searching for a result or if it has finished and
didn't find anything, so I often wait a few seconds to see if it's going to do
anything.  A nice quick "Not found" in the status bar (perhaps accompanied by
turning the textbox red) would prevent this frustration.

I also would like to see "Searching..." to appear if the searching is taking a
while.

Comment 4

[Blake Ross]

Fixed on branch.

Don't need to leave open for trunk since I have bug 250231 and all these fixes
will land as part of that.

Comment 5

[Worcester12345]

Not sure if this is the place, but the close button is way way too small. Same
as the close tab "x" button. I think there is a bug for that one, but can't
remember or find it. Not sure if this issue should go here, under that bug, or
on its own.

Comment 6

[Alex Eng]

Have a look at bug 250648. In addition to a decently-sized Close button, it also
proposes that it be moved closer to the other Find Bar buttons, so that it's not
placed so far to the right as it is now.