25052 - Text obscured by resize handle on Mac "Create New Profile"

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect, P3)

Description

[Nick Meara]

Overview Description:

The text that describes the current position of the user within the "Create New 
Profile" procedure, e.g. 1 of 2 etc., is obscured by the window's resize handle.

Steps to Reproduce:

1) Remove the file "Mozilla Registry" from the Preferences folder to ensure that 
the "Create New Profile" wizard is launched.
2) Start Mozilla.

Build Date & Platform:

2000012509 Mac OS 8.6

Comment 1

[Nick Meara]

Attachment: Screenshot of window handle obscuring text

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

these windows should not be resizable. giving to seth...

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

oops, my mistake

Comment 4

[(not reading, please use [e-mail] instead)]

racham, 

you'll want to tweak line 290 of nsProfile.cpp from

rv = profAppShell->CreateTopLevelWindow(nsnull, profileURL, PR_TRUE, PR_TRUE,
NS_CHROME_ALL_CHROME, 

to something like

rv = profAppShell->CreateTopLevelWindow(nsnull, profileURL,
                                                PR_TRUE, PR_TRUE,
NS_CHROME_OPEN_AS_DIALOG | NS_CHROME_WINDOW_CLOSE_ON |
NS_CHROME_WINDOW_BORDERS_ON,

see
http://lxr.mozilla.org/seamonkey/source/webshell/public/nsIBrowserWindow.h#45
for flags to pass in.

but be warned, I think linux has know problems with opening a window and making
it "not resizable".  but they may be fixed by now. 

Comment 5

[Dan M]

The resizing problem Seth mentions is bug 17936. It's been fixed.

Comment 6

[racham]

Just need to test the suggested fix on Mac. Marking M14. Accepting the bug.

Comment 7

[(not reading, please use [e-mail] instead)]

that sample code I submitted isn't a fix, it's a suggestion.
you'll need to figure out the right flags.

Comment 8

[racham]

That's true. However, FYI, those flags provided good exmaple when tried on 
windows. I will look for right flags and make the window to take right shape.

Comment 9

[racham]

Have the fix in hand. 
Will checkin with other fixes.

Comment 10

[racham]

This is a small change to CHROME style. Mac just needed borders.on and 
closewindow.on. Windows and Linux are fine. Checked this fix. Marking fixed.

Comment 11

[Grace Bush]

build 2000021608

Comment 12

[racham]

*** Bug 26099 has been marked as a duplicate of this bug. ***