Closed Bug 250625 Opened 21 years ago Closed 21 years ago

Deleting RSS Folders

Categories

(MailNews Core :: Feed Reader, defect)

Product:
MailNews Core
Component:
Feed Reader
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mscott, Assigned: Bienvenu)

References

Details

(Keywords: fixed-aviary1.0)

Attachments

(2 files, 1 obsolete file)

skip trash approach
7.16 KB, patch
Details | Diff | Splinter Review
skip confirmation approach
1.85 KB, patch
mscott
: superreview+
Details | Diff | Splinter Review
When you delete an RSS feed from the Manage Subscriptions dialog, we are moving the feed to the Trash folder. As a result the mail 3-pane window comes to the front on top of the subscription dialog. The user gets a prompted confirming the deletion of a folder to Trash. After dismissing the dialog you then have to go find the subscription dialog again. Two things: 1) I wonder if we should just skip the delete to trash for a feed. If you restore the folder, I bet our subscription UI doesn't recognize that we have a restored feed. 2) If we do still support delete to trash, I think we should try to supress the prompt if we are deleting an RSS folder (vs. a regular mail folder). Or at the very least, parent the prompt from the subscription windows somehow.
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird0.8
yep, definitely need to do something about this - I think skipping the trash is the way to go. The rss data can be restored from the server, so I don't think the trash is that useful. I can look into this...
Assignee: mscott → bienvenu
Status: ASSIGNED → NEW
I tried skipping the trash and listening to the item removed notification. The problem here is that by the time we get the item removed notification, we've already deleted the .msf file (if we skip the delete to trash part). This makes it difficult or impossible to figure out what feeds were going into the folder, because that info is stored in the db, which is already deleted. Short of sticking this info in the folder object, I don't think my current approach is going to work.
this approach doesn't work because the db has already been deleted. But if we can find a way around that problem, this would be an interesting approach.
I'll try to come up with a patch that just supresses the prompt.
suppressing the prompt seems like a good way to go
Attached patch skip confirmation approach (obsolete) — — Splinter Review
Comment on attachment 155303 [details] [diff] [review] skip confirmation approach wrong patch...
Attachment #155303 - Attachment is obsolete: true
Attachment #155304 - Flags: superreview?(mscott)
Attachment #155304 - Flags: superreview?(mscott) → superreview+
fixed on trunk and branch.
Status: NEW → RESOLVED
Closed: 21 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
*** Bug 267109 has been marked as a duplicate of this bug. ***
*** Bug 268056 has been marked as a duplicate of this bug. ***
*** Bug 292843 has been marked as a duplicate of this bug. ***
*** Bug 306387 has been marked as a duplicate of this bug. ***
*** Bug 268056 has been marked as a duplicate of this bug. ***
Component: RSS → Feed Reader
Product: Thunderbird → MailNews Core
Target Milestone: Thunderbird0.8 → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: