250815 - reference to undefined property column.id in unifinder (strict js warning on Moz1.7/1.8 tree capatibility code)

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2

On moz1.7, with cvs cal, running with strict javascript produces warning: 
  reference to undefined property column.id
in several places in
  unifinder.js
  unifinderToDo.js

Problem is Moz1.7/Moz1.8 tree compatibility code that checks for column.id when
column is a string (in moz1.7).  Safer approach is to check the type of column
is an object before accessing id property.

Instead of 
   (column.id || column)
use
   (typeof(column)=="object" ? column.id : column)




Reproducible: Always
Steps to Reproduce:

Comment 1

[gekacheka]

Attachment: unifinder.js, unifinderToDo.js patch: (col.id || col) --> (typeof(col)=="object"? col.id : col)

Comment 2

[gekacheka]

Works on Moz1.7.1 and Moz1.8 (sunbird).

Comment 3

[Mostafa Hosseini]

Checked in. Thanks

Comment 4

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!