250824 - Setting datepicker.disabled = true doesn't work (setAttribute does)

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2

In calendar from cvs on Moz1.7 or sunbird (1.8):

Setting 
  datepicker.disabled = true;
doesn't work (not disabled).  
Workaround: datepicker.setAttribute("disabled", true)

Setting 
  datetimepicker.disabled = true;
only disables timepicker subcomponent, not datepicker subcomponent.

Difference is timepicker.xbl provides a .disabled property which disables
components, while datepicker does not. 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[gekacheka]

Attachment: datepicker.xbl, timepicker.xbl patch: add datepicker.disabled property, update comments

datepicker.xbl
  add property "disabled", calls method "setDisabled"
  constructor:	
     set this.kButton (used by setDisabled)
     rename this.kCalendar to this.kMinimonth (component was renamed)
     init this.disabled to attribute value
  fix indentation of method parameters
  add method "setDisabled", sets subcomponent attributes

timepicker.xbl
  add comment to disabled property
  constructor:	init disabled property from attribute value
  setDisabled: remove obsolete comments

Comment 2

[gekacheka]

Works on Moz1.7 and sunbird (1.8)

Tests:
  eventDialog allDay checkbox still enables/disables timepickers, not datepickers.
  after bug 220075 patches todoDialog.js, start or due checkbox enables/disables
both its datepicker and timepicker in same row.

Comment 3

[Mostafa Hosseini]

Checked in . Thanks

Comment 4

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!