Closed
Bug 250858
Opened 20 years ago
Closed 20 years ago
Focus outlines showing up in unwanted places
Categories
(Core :: Layout, defect, P2)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: waynegwoods, Assigned: aaronlev)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
232 bytes,
text/html
|
Details | |
703 bytes,
patch
|
bryner
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a2) Gecko/20040710 Firefox/0.9.0+ Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a2) Gecko/20040710 Firefox/0.9.0+ Related to bug 250169 and bug 171366. I assume this will turn out to be a Browser bug of All/All, but Mac Firefox is all I can test tonight. I looked, but couldn't find a dupe that fit. If you click on an image in a web page which is also a link (attachment will follow), then a focus outline appears around the image. This outline only appears since 20040707 (see the above bug). I'm not sure if it is intentional for the outline to appear now, or not. If not, then I guess this bug is about that, otherwise it's about the following: If you opt to "Open Link in New Tab", then the focus outline persists around the image afterwards. If you click somewhere else on the page, you can make it go away. HOWEVER: If you don't click to remove the outline, but instead immediately switch to another tab, and then switch back to the original tab, the focus outline remains around the image and it won't go away even if you click elsewhere in the page. Reproducible: Always Steps to Reproduce: 1.Go to a page with a simple gif icon as a link (e.g. see attachment) 2.Click on the link and opt to open link in a new tab (select from context menu) 3.Observe that focus outline appears around image 4.Don't touch original page, but instead click on the new tab (or any other open tab) 5.Return to original tab 6.Observe that focus outline is still present around image 7.Click somewhere else in the page 8.Observe that focus outline is still present around image and won't go away Actual Results: Focus outline around image won't go away Expected Results: Focus outline should be gone (if it was meant to be there in the first place) Can someone reproduce this in other OSs and in Mozilla? If not, I'll do so tomorrow and reset the parameters accordingly.
Reporter | ||
Comment 1•20 years ago
|
||
Open the page. Click (click-hold or right-click) on the Mozilla button in the page to bring up a context menu and select "Open Link in New Tab". Don't touch the attachment page, but switch tabs, and then come back to the attachment page. Click somewhere on the page. The focus outline around the image will remain, when it should go away.
Reporter | ||
Comment 2•20 years ago
|
||
Bug now confirmed in Windows XP for the 20040711 trunk builds of both Firefox and Seamonkey. Setting to Browser and All/All.
Assignee: firefox → nobody
Component: General → Layout
OS: MacOS X → All
Product: Firefox → Browser
QA Contact: firefox.general → core.layout
Hardware: Macintosh → All
Version: unspecified → Trunk
Comment 3•20 years ago
|
||
I can confirm the bug. Middle-clicking to open the link in a new tab, going to the new tab and then returning, you can't remove the focus outline of the link. With the old behavior of Mozilla, by the way, you can't see any focus outline with middle clicking or right clicking. I think this is an improvement. However, another problem I can see with the testcase: Tabbing through (using the TAB key) doesn't show the focus outline anymore. In old versions of Mozilla it did. Another regression of fixing bug 171366?
Comment 4•20 years ago
|
||
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a2) Gecko/20040711 Just use the Mozilla logo on top of this page, and you see a white vertical line separating the image from the dark background to the right. If I right click on the image, the line is seen, if I close the context menu, the line vanishes. It stays however, if I open the link in a new tab. Clicking somewhere, it is hidden. Not clicking, but going to the new tab, and returning, it stays, even if I click somewhere on this page. It is hidden however, if I open context menu on the image, and close it.
Assignee | ||
Comment 5•20 years ago
|
||
I also notice that now clicking on the bold word in a Google search result link causes a focus outline to surround just the bold part.
Assignee: nobody → aaronleventhal
Priority: -- → P2
Comment 6•20 years ago
|
||
(In reply to comment #5) > I also notice that now clicking on the bold word in a Google search result link > causes a focus outline to surround just the bold part. Yes, I noticed that too. I also noticed that "anorexic anchors" can get focus (which they shouldn't) when they are targetted. See: http://home.hccnet.nl/m.wargers/test/mozilla/targetbug.htm#test
Assignee | ||
Comment 7•20 years ago
|
||
Making the bug more general, because the fix should be the same for all the problems listed so far.
Summary: Focus outline around image links won't go away → Focus outlines showing up in unwanted places
Comment 8•20 years ago
|
||
Another thing that has changed, focus for image maps: http://www.december.com/html/demo/imagemap.html The focus shifts directly to the entire image map when you click with the mouse. This did not happen before. The focus stayed at the area it was active in. It is most easily seen with the yellow area, because that won't take you to another url. (I post this, because this is yet another situation, it might be useful)
Assignee | ||
Comment 9•20 years ago
|
||
Bug 250006 is where I'm doing the work for this one. *** This bug has been marked as a duplicate of 250006 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 10•20 years ago
|
||
Sorry, not a dup. I meant "depends on"
Comment 11•20 years ago
|
||
I have another (I think) regression of bug 171366. http://erik.eae.net/archives/2004/07/13/00.05.28/#comments In this page, you can't really select any text in the textboxes with the mouse. This worked in 2004-07-06 builds, but not anymore in 2004-07-07 builds. Should I file a new bug on this? (with an simple testcase)
Assignee | ||
Comment 12•20 years ago
|
||
(In reply to comment #11) > I have another (I think) regression of bug 171366. > http://erik.eae.net/archives/2004/07/13/00.05.28/#comments > In this page, you can't really select any text in the textboxes with the mouse. > This worked in 2004-07-06 builds, but not anymore in 2004-07-07 builds. > Should I file a new bug on this? (with an simple testcase) > That was bug 250692.
Comment 13•20 years ago
|
||
see also bug 251400: focus outline is NOT showing up in WANTED places..
Comment 14•20 years ago
|
||
*** Bug 251400 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 15•20 years ago
|
||
Bug 250006 was checked in which should fix the 3 problems listed here: * Spurious focus outlines on linked images * Focus shifting to entire image map after clicking on image map area * Clicking on the a link with different formats (like bold and normal text) putting a focus outline on just 1 part of the link
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Comment 16•20 years ago
|
||
(In reply to comment #15) > Bug 250006 was checked in which should fix the 3 problems listed here: > * Spurious focus outlines on linked images That seems to be solved, but the focus outline in the attached testcase looks ugly. It seems like there is an extra focus outline at the bottom. > * Focus shifting to entire image map after clicking on image map area That doesn't seem to be solved. > * Clicking on the a link with different formats (like bold and normal text) > putting a focus outline on just 1 part of the link That seems to be solved Also the bug mentioned in comment 6 seems to be solved. Checked with: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a3) Gecko/20040725
Comment 17•20 years ago
|
||
*** Bug 253154 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 18•20 years ago
|
||
Reopening per issues remaining in comment 16. Thanks Martijn. I thought I had all of those issues fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 19•20 years ago
|
||
Will deal with funny focus outlines at the bottom of image links later.
Assignee | ||
Updated•20 years ago
|
Attachment #154573 -
Flags: review?(bryner)
Updated•20 years ago
|
Attachment #154573 -
Flags: review?(bryner) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #154573 -
Flags: superreview?(jst)
Assignee | ||
Comment 20•20 years ago
|
||
Filed a separate bug 253593 on strange image link outlines.
Comment 21•20 years ago
|
||
Comment on attachment 154573 [details] [diff] [review] Fix problem with image map areas sr=jst
Attachment #154573 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Comment 22•20 years ago
|
||
Checking in nsHTMLImageElement.cpp; /cvsroot/mozilla/content/html/content/src/nsHTMLImageElement.cpp,v <-- nsHTMLImageElement.cpp new revision: 1.181; previous revision: 1.180 done
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•