251039 - rohan.co.uk - uses document.all for store locator

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: English Other, defect)

Description

[Harold Fuchs]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Firefox/0.8

Please try the following: 

1. Go to http://www.rohan.co.uk/ 
2. Click "Store Locator" (top right) 
3. Open the Javascript console (Tools -> Javascript Console) 
4. In the Store Locator from step #2, click in one of the coloured regions of
the map. 

The Javascript console will show an error: 
"Error: document.all has no properties 
Source File: http://www.rohan.co.uk/Static/en-GB/script/storelocation.js 
Line: 56" 

If you try this in IE6.0 you get a list of stores in the region in which you
clicked in step #4. 

Now, I have read your FAQ where it says that document.all is not supported by
the W3C. I accept that you may feel that therefore this is not a bug. On the
other hand, if you'd like to continue stealing market share from M$ then you
might want to fix this anyway.

Reproducible: Always
Steps to Reproduce:
1. Go to http://www.rohan.co.uk/ 
2. Click "Store Locator" (top right) 
3. Open the Javascript console (Tools -> Javascript Console) 
4. In the Store Locator from step #2, click in one of the coloured regions of
the map.

Actual Results:  
The Javascript console will show an error: 
"Error: document.all has no properties 
Source File: http://www.rohan.co.uk/Static/en-GB/script/storelocation.js 
Line: 56" 

Expected Results:  
You should see a list of the stores in the geographic region in which you
clicked in step #4.

Works in IE6.0 so there's a strong argument (IMHO) that it should work in
Forefox also.

As far as I'm concerned this "bug" would prevent me from using Firefox; the
"document.all" feature seems to be common enough to be regarded as a de facto
standard, regardless of that the W3C says.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

-> tech evang, the site should not use document.all....

on the other hand, bug 248549 may get this site to work

Comment 2

[Nick Dixon]

(In reply to comment #1)
> -> tech evang, the site should not use document.all....
> 
> on the other hand, bug 248549 may get this site to work

I can confirm that this works as intended with Mozilla 1.8a3 and recent Firefox
nightlies:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a3) Gecko/20040820
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040826 Firefox/0.9.1+

JS Console shows the new W3C/document.all warning.

Comment 3

[Bob Clary [:bc] (inactive)]

excellent.