251241 - Both zh-Hant and zh-Hans are treated as zh-CN

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jungshik Shin]

In the test case at the URL given in the URL field, zh-Hant and zh-Hans are both
treated as zh. We can easily fix this problem by adding two entries to the
mapping table (langGroups.properties). However, it might not be the best way to
deal with the problem in general.

zh-hans=zh-CN
zh-hant=zh-TW

Richard, you can edit the file (in 'res' subdirectory of your mozilla
installation directory) to add the entries above.

Comment 1

[Jungshik Shin]

Simon, what do you think of adding two entries to langGroups.properties file? 

Comment 2

[Simon Montagu :smontagu]

I am OK with it as a quick fix, but ideally we want to move towards a general
solution for parsing ISO 15924 script codes as part of the lang attribute.

Comment 3

[Jungshik Shin]

Attachment: a quick fix

I fully agree with you about the characteristic of the patch (an intertim
patch) so that I added a comment to that effect.

Comment 4

[Jungshik Shin]

Comment on attachment 154466 [details] [diff] [review]
a quick fix

asking for r/sr

as an quick --> as a quick fix.

they have ... revisited => the issue has ... revisited.

Comment 5

[Richard Ishida]

Note, for clarity, that zh-hans and zh-hant are actually defined by IANA as
language tags, though they use iso 15924 script codes.  Note also that the
so-called rfc3066bis will support the use of script codes within language tags.

Comment 6

[Simon Montagu :smontagu]

Yes indeed: rfc3066bis is the hidden leitmotif behind my comment 2 (and various
similar comments in other bugs - e.g. bug 192636)

Comment 7

[Jungshik Shin]

Comment on attachment 154466 [details] [diff] [review]
a quick fix

trying Neil for sr.
this is a trivial fix although it's sort of a stop-gap.

Comment 8

[Jungshik Shin]

Comment on attachment 154466 [details] [diff] [review]
a quick fix

thanks for sr.
fix checked into the trunk.

asking for a for check-in to aviary-1.0 and 1.7 branches 

This is a trivial fix but it'd be nice to fix this for 1.7 branch/aviary-1.0

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 154466 [details] [diff] [review]
a quick fix

a=[e-mail]

Comment 10

[Jungshik Shin]

thanks for a. fixed on aviary-1.0

Comment 11

[Mike Kaply [:mkaply]]

Comment on attachment 154466 [details] [diff] [review]
a quick fix

a=mkaply for 1.7.3

Comment 12

[Jungshik Shin]

fixed on 1.7branch as well

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When this was landed on aviary 1.0, it was merged manually, with s/the/this/,
which causes pain for those synchronizing branches.  Please use cvs to merge
patches to branches.