251279 - No tooltip for "From:" in collapsed/brief header if sender isn't in Address Book

Status: RESOLVED FIXED

Description

[Ben Ruppel]

In the 3-pane view, when the header in the message pane is collapsed, only the
"friendly" name of the message sender is shown after "From:"

It would be very nice if there was a tooltip for this name that showed the
sender's email address.  Right now, one would have to expand the header or copy
the email address using the name's context menu.

It was fixed back in 2002 for the suite, see bug 90368.  Maybe someone could use
that patch code.
http://bugzilla.mozilla.org/show_bug.cgi?id=90368

Comment 1

[Ivan Ičin]

I have the same problem, but not just limited to three column view

Comment 2

[Mike Cowperthwaite]

This works for me with TB 1.0, Win2K.  Ben Ruppel, if you also see this working 
as expected, please mark this bug:   Resolved | WorksForMe

Comment 3

[Ben Ruppel]

Mike, I apologize but I am not at a computer where I can confirm or deny this 
and I won't be until Jan 3.  I will mark this bug resolved or respond otherwise 
on that date.

Comment 4

[Mike Cowperthwaite]

No response from reporter; =>WFM

Comment 5

[Ben Ruppel]

(In reply to comment #4)
> No response from reporter; =>WFM

Nope, just tried it with Jan 29 trunk build and it is still broken.  Excuse me
for forgetting to respond.

Comment 6

[Ben Ruppel]

Oh crud, sorry Mike.  This works for me, I wasn't checking for the tooltip properly.

Comment 7

[Ben Ruppel]

No, wait!  It seems to work, but only for email addresses in my address book. 
So when I get emails from people I know their addresses show up as tooltips, but
when I get emails from people not in my address book there is no tooltip.  For
example, an email from Verizon does not have a tooltip showing the sender's true
address because that address is not in my address book. 

I will open this.  Let me know if I should change the summary or file a
different bug.

Comment 8

[Mike Cowperthwaite]

This is also a problem if the sender is in, say, the Collected Addresses.

See bug 305204.

Comment 9

[Žiga Sancin]

Created attachment 209776 [details] [diff] [review]
patch

The if statement is far too restrictive... The function useDisplayNameForAddress(); returns false for addresses that are not in the Personal AB, so these addresses don't get the tooltiptext attribute. We should move the function out of the if statement.

Comment 10

[Žiga Sancin]

Oops, not out of the if statement, just out of the conditions...

Comment 11

[Mike Cowperthwaite]

*** Bug 241763 has been marked as a duplicate of this bug. ***

Comment 12

[Mike Cowperthwaite]

Scott, could we get this simple patch reviewed, pls?

Comment 13

[Scott MacGregor]

Comment on attachment 209776 [details] [diff] [review]
patch

sure!

Comment 14

[Scott MacGregor]

Gavin might be able to check this in for you. 

Comment 15

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/base/content/msgHdrViewOverlay.js 	1.56.2.19
mozilla/mail/base/content/msgHdrViewOverlay.js 	1.78

Comment 16

[Scott MacGregor]

oops, I think this patch broke: Bug 348860.