No event point for wheel scroll event

RESOLVED FIXED

Status

RESOLVED FIXED
15 years ago
10 years ago

People

(Reporter: sergei_d, Assigned: sergei_d)

Tracking

({fixed-aviary1.0})

Trunk
x86
BeOS
fixed-aviary1.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.25 KB, patch
thesuckiestemail
: review+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
Current implementation in widget/src/beos/nsWindow.cpp reports fixed point
(100,100) for NS_MOUSE_SCROLL.
It results in stupid bugs on pages with scrollable iframe, like stopping of
scrolling main content when iframe gets visible. On some pages it is impossible
at all to scroll main content.

Fix seems simple - adding GetMouse() to get cursor position,
but it leads to strange behaviour - if you reached bottom of page, scroll-up
moves to top of page, instead moving up for scroll-step.

So investigating
(Assignee)

Comment 1

15 years ago
oops, no problem with scrol-up. was stupid side-effect of another change in code.

Submitting fix soon
Assignee: beos → sergei_d
(Assignee)

Comment 2

15 years ago
Created attachment 153224 [details] [diff] [review]
patch. diff -up4

gets cursor coordinates and assigns those to even point.
compare wheel behaviour before and after patch 
here:
http://beos.spb.ru/mozilla/frametest/testmain.html

before patch wheel scrolling scrolls rather iframe than main page.
after patch wheel scroll object at which it's over.

Updated

15 years ago
Attachment #153224 - Flags: review+
(Assignee)

Comment 3

15 years ago
Comment on attachment 153224 [details] [diff] [review]
patch. diff -up4

need to remove XXX comment
Attachment #153224 - Attachment is obsolete: true
(Assignee)

Comment 4

15 years ago
Created attachment 153227 [details] [diff] [review]
patch

same as above but comment removed.
(Assignee)

Comment 5

15 years ago
Comment on attachment 153227 [details] [diff] [review]
patch

asking for review
Attachment #153227 - Flags: review?(thesuckiestemail)

Comment 6

15 years ago
Comment on attachment 153227 [details] [diff] [review]
patch

r=thesuckiestemail@yahoo.se
Attachment #153227 - Flags: review?(thesuckiestemail) → review+
(Assignee)

Comment 7

15 years ago
fixed.
new revision: 1.82
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 8

14 years ago
Checkin on AVIARY by db48x%yahoo.com 
 
"Check in several BeOS bugs that are already checked in on the trunk. All are 
r=twh (thesuckiestemail@yahoo.se) except the last which is r=Sergei Dolgov 
(sergei_d@fi.tartu.ee). a=carte blanche ([03:53:40] 
<nielx!~nielx@84.119.151.125> We've been basically given a carte blanche for 
any change that involves the beos-only code)" 

Updated

14 years ago
Keywords: fixed-aviary1.0
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.