25136 - scary floater assertion loading wired URL

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[buster]

nsBlockFrame::BuildFloaterList() assigned an nsTableOuterFrame as a next sibling 
to itself.  very bad.  though continuing past the assertion allows the page to 
lay out correctly.

assigning to troy in case he has been in this code lately.  cc-ing nisheeth as 
well, just for kicks.  troy, if it isn't yours just dump it into kipp's pile.

stack:
nsDebug::Assertion(const char * 0x01e26af0, const char * 0x01e26ad8, const char 
* 0x01e26aac, int 1626) line 189 + 13 bytes
nsFrame::SetNextSibling(nsFrame * const 0x022888b8, nsIFrame * 0x022888b8) line 
1626 + 34 bytes
nsBlockFrame::BuildFloaterList() line 6456
nsBlockFrame::Reflow(nsBlockFrame * const 0x02223340, nsIPresContext * 
0x02c8c670, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0) line 1549
nsBlockReflowContext::ReflowBlock(nsIFrame * 0x02223340, const nsRect & {...}, 
int 1, int 0, int 1, nsMargin & {...}, unsigned int & 0) line 291 + 45 bytes
nsBlockFrame::ReflowBlockFrame(nsBlockReflowState & {...}, nsLineBox * 
0x02d7bea0, int * 0x0012eb2c) line 3416 + 59 bytes
nsBlockFrame::ReflowLine(nsBlockReflowState & {...}, nsLineBox * 0x02d7bea0, int 
* 0x0012eb2c, int 1) line 2746 + 23 bytes
nsBlockFrame::ReflowDirtyLines(nsBlockReflowState & {...}) line 2557 + 27 bytes
nsBlockFrame::Reflow(nsBlockFrame * const 0x022232f4, nsIPresContext * 
0x02c8c670, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0) line 1532 + 15 bytes
nsAreaFrame::Reflow(nsAreaFrame * const 0x022232f4, nsIPresContext * 0x02c8c670, 
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0) 
line 272 + 25 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x022232f4, nsIPresContext * 
0x02c8c670, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 0, 
int 0, unsigned int 0, unsigned int & 0) line 637 + 31 bytes
RootFrame::Reflow(RootFrame * const 0x02263074, nsIPresContext * 0x02c8c670, 
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0) 
line 331
nsContainerFrame::ReflowChild(nsIFrame * 0x02263074, nsIPresContext * 
0x02c8c670, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 0, 
int 0, unsigned int 1, unsigned int & 0) line 637 + 31 bytes
nsScrollPortFrame::Reflow(nsScrollPortFrame * const 0x022630fc, nsIPresContext * 
0x02c8c670, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0) line 404
nsContainerFrame::ReflowChild(nsIFrame * 0x022630fc, nsIPresContext * 
0x02c8c670, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 0, 
int 0, unsigned int 3, unsigned int & 0) line 637 + 31 bytes
nsGfxScrollFrameInner::ReflowFrame(nsIPresContext * 0x02c8c670, 
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0, 
nsIFrame * 0x022630fc, const nsSize & {...}, const nsSize & {...}, int & 0, 
nsIFrame * & 0x00000000) line 1239
nsGfxScrollFrameInner::ReflowScrollArea(nsIPresContext * 0x02c8c670, 
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0, 
int & 0, int & 0, int & 1, nsIFrame * & 0x00000000) line 1307
nsGfxScrollFrame::Reflow(nsGfxScrollFrame * const 0x022630b0, nsIPresContext * 
0x02c8c670, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0) line 509
nsContainerFrame::ReflowChild(nsIFrame * 0x022630b0, nsIPresContext * 
0x02c8c670, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 0, 
int 0, unsigned int 0, unsigned int & 0) line 637 + 31 bytes
ViewportFrame::Reflow(ViewportFrame * const 0x02263038, nsIPresContext * 
0x02c8c670, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0) line 531
nsHTMLReflowCommand::Dispatch(nsHTMLReflowCommand * const 0x02b09080, 
nsIPresContext * 0x02c8c670, nsHTMLReflowMetrics & {...}, const nsSize & {...}, 
nsIRenderingContext & {...}) line 145
PresShell::ProcessReflowCommands(PresShell * const 0x02d43790, int 0) line 1940
PresShell::ExitReflowLock(PresShell * const 0x02d43790, int 1) line 848
PresShell::ContentAppended(PresShell * const 0x02d43798, nsIDocument * 
0x02c86370, nsIContent * 0x02d4e2cc, int 0) line 2473
nsDocument::ContentAppended(nsDocument * const 0x02c86370, nsIContent * 
0x02d4e2cc, int 0) line 1545
nsHTMLDocument::ContentAppended(nsHTMLDocument * const 0x02c86370, nsIContent * 
0x02d4e2cc, int 0) line 1118
HTMLContentSink::NotifyAppend(nsIContent * 0x02d4e2cc, int 0) line 3785
SinkContext::FlushTags() line 1833
HTMLContentSink::CloseBody(HTMLContentSink * const 0x02c84260, const 
nsIParserNode & {...}) line 2600
CNavDTD::CloseBody(const nsIParserNode * 0x02d47190) line 2696 + 31 bytes
CNavDTD::CloseContainer(const nsIParserNode * 0x02d47190, nsHTMLTag 
eHTMLTag_body, int 0) line 2992 + 12 bytes
CNavDTD::CloseContainersTo(int 1, nsHTMLTag eHTMLTag_body, int 0) line 3049 + 20 
bytes
CNavDTD::CloseContainersTo(nsHTMLTag eHTMLTag_body, int 0) line 3204 + 20 bytes
CNavDTD::DidBuildModel(CNavDTD * const 0x02d47800, unsigned int 0, int 1, 
nsIParser * 0x02c84380, nsIContentSink * 0x02c84260) line 625
nsParser::DidBuildModel(unsigned int 0) line 587 + 55 bytes
nsParser::ResumeParse(nsIDTD * 0x00000000, int 1) line 1017
nsParser::OnStopRequest(nsParser * const 0x02c84384, nsIChannel * 0x02c849b0, 
nsISupports * 0x00000000, unsigned int 0, const unsigned short * 0x00000000) 
line 1407 + 19 bytes
nsDocumentOpenInfo::OnStopRequest(nsDocumentOpenInfo * const 0x02c80fc0, 
nsIChannel * 0x02c849b0, nsISupports * 0x00000000, unsigned int 0, const 
unsigned short * 0x00000000) line 202
InterceptStreamListener::OnStopRequest(InterceptStreamListener * const 
0x02c87fd0, nsIChannel * 0x02c849b0, nsISupports * 0x00000000, unsigned int 0, 
const unsigned short * 0x00000000) line 1113
nsHTTPChannel::ResponseCompleted(nsIChannel * 0x02c7a034, nsIStreamListener * 
0x02c87fd0, unsigned int 0, const unsigned short * 0x00000000) line 1307 + 36 
bytes
nsHTTPResponseListener::OnStopRequest(nsHTTPResponseListener * const 0x02bedf00, 
nsIChannel * 0x02c7a034, nsISupports * 0x02c849b0, unsigned int 0, const 
unsigned short * 0x00000000) line 256
nsOnStopRequestEvent::HandleEvent(nsOnStopRequestEvent * const 0x03264480) line 
279
nsStreamListenerEvent::HandlePLEvent(PLEvent * 0x03264430) line 93 + 12 bytes
PL_HandleEvent(PLEvent * 0x03264430) line 526 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00cbfc90) line 487 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x02790294, unsigned int 49319, unsigned int 0, 
long 13368464) line 975 + 9 bytes
USER32! 77e71250()

Comment 1

[troy]

Don't assign this to me. You know what I think of the floater code, and it's 
your decision to leave it the way it is. That means you get to fix the floater 
bugs...

Comment 2

[buster]

per my original comment, assigning to kipp for now.  putting in M16 milestone, 
since the layout is correct and the end user won't see a problem.

Comment 3

[buster]

kipp is very unlikely to fix these, since he's not working ont he project any 
longer.  so I'll take a look.

Comment 4

[buster]

fix for 29595 fixed this also

Comment 5

[Chris Petersen]

Url is no longer valid. Marking verified per last comments.