Closed
Bug 251501
Opened 20 years ago
Closed 20 years ago
refactor handling of where frames get inserted for child content
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
Details
Attachments
(1 file, 1 obsolete file)
19.88 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
Currently nsCSSFrameConstructor::GetFrameFor has some ghastly code to figure out where to insert the frames for child content. It would be much better to replace this with a method on nsIFrame that determines where child content frames should be inserted.
Assignee | ||
Comment 1•20 years ago
|
||
The reason I need this, by the way, is because columns need similar delegation and I couldn't bear to extend GetFrameFor. But this code cleanup feels good on its own.
Assignee | ||
Comment 2•20 years ago
|
||
This is the right patch
Attachment #153254 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #153255 -
Flags: superreview?(dbaron)
Attachment #153255 -
Flags: review?(dbaron)
Comment on attachment 153255 [details] [diff] [review] that was the wrong patch... What's up with ConstructBlock? You're changing the callers and the signature without changing the function itself. I'm assuming that's for some other patch and you just forgot to remove it. Other than that this seems fine.
Attachment #153255 -
Flags: superreview?(dbaron)
Attachment #153255 -
Flags: superreview+
Attachment #153255 -
Flags: review?(dbaron)
Attachment #153255 -
Flags: review+
Assignee | ||
Comment 4•20 years ago
|
||
Correct. The ConstructBlock changes are for the actual column frame implementation and I forgot to edit them out. Thanks.
Assignee | ||
Comment 5•20 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•