Closed
Bug 251646
Opened 20 years ago
Closed 20 years ago
clicking "highlight" in the find toolbar does not restart visible timer
Categories
(Toolkit :: Find Toolbar, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.7.4
People
(Reporter: mikeclackler, Assigned: mikeclackler)
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file, 1 obsolete file)
1.00 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040714 Firefox/0.9.1+ (MOOX-AV) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040714 Firefox/0.9.1+ (MOOX-AV) The find toolbar is on a timer that controls how long the toolbar is visible (approx 5 sec). Pressing a key or clicking "Find Next" or "Find Previous" resets this timer since you are actively using the toolbar. Clicking "highlight" should also reset the display timer like "find next/previous" since you are using the toolbar, but the timer is not reset. Reproducible: Always Steps to Reproduce: 1.activate the find toolbar 2.wait approx 4 seconds and click "Highlight" 3. Actual Results: The toolbar closes within approx. 1 second Expected Results: The toolbar should have remained visible for approx. 5 seconds after "Highlight" was clicked before it closed
Comment 1•20 years ago
|
||
I can confirm this behavior, OS -> ALL Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040725 Firefox/0.9.1+
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Summary: clicking "highlight" in the find toolbad does not restart visible timer → clicking "highlight" in the find toolbar does not restart visible timer
Assignee | ||
Comment 2•20 years ago
|
||
This patch adds "if (gFindMode != FIND_NORMAL) setFindCloseTimeout();" to the highlight toolbarbutton oncommand. The patch fixes this problem by restarting the find toolbar close timer when the highlight button is pressed in FAYT mode. I hope the patch is in the correct format, this is my first.
Assignee | ||
Comment 3•20 years ago
|
||
Here's the patch in a better format. I had bad line feed charaters in the last patch causing the patch to replace the complete file.
Attachment #154727 -
Attachment is obsolete: true
Assignee | ||
Comment 4•20 years ago
|
||
Comment on attachment 154823 [details] [diff] [review] patch - v2 makes highlight button reset close counter
Attachment #154823 -
Flags: review?(firefox)
Assignee | ||
Comment 5•20 years ago
|
||
requesting blocking-aviary1.0PR since patch exists
Flags: blocking-aviary1.0PR?
Updated•20 years ago
|
Whiteboard: [have patch]
Updated•20 years ago
|
Attachment #154823 -
Flags: review?(firefox) → review+
Comment 6•20 years ago
|
||
Steffen, have you got a moment to check this one-liner in?
Comment 7•20 years ago
|
||
Checked into branch, with some added whitespace to make it look nicer. -> mikeclackler@hotmail.com.
Assignee: firefox → mikeclackler
Hardware: PC → All
Target Milestone: --- → Firefox1.0beta
Comment 8•20 years ago
|
||
-> fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Flags: blocking-aviary1.0PR?
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: [have patch]
Version: unspecified → 1.0 Branch
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•