User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040714 Firefox/0.9.1+ (MOOX-AV) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040714 Firefox/0.9.1+ (MOOX-AV) The find toolbar is on a timer that controls how long the toolbar is visible (approx 5 sec). Pressing a key or clicking "Find Next" or "Find Previous" resets this timer since you are actively using the toolbar. Clicking "highlight" should also reset the display timer like "find next/previous" since you are using the toolbar, but the timer is not reset. Reproducible: Always Steps to Reproduce: 1.activate the find toolbar 2.wait approx 4 seconds and click "Highlight" 3. Actual Results: The toolbar closes within approx. 1 second Expected Results: The toolbar should have remained visible for approx. 5 seconds after "Highlight" was clicked before it closed
I can confirm this behavior, OS -> ALL Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040725 Firefox/0.9.1+
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Summary: clicking "highlight" in the find toolbad does not restart visible timer → clicking "highlight" in the find toolbar does not restart visible timer
Created attachment 154727 [details] [diff] [review] patch to fix This patch adds "if (gFindMode != FIND_NORMAL) setFindCloseTimeout();" to the highlight toolbarbutton oncommand. The patch fixes this problem by restarting the find toolbar close timer when the highlight button is pressed in FAYT mode. I hope the patch is in the correct format, this is my first.
Created attachment 154823 [details] [diff] [review] patch - v2 Here's the patch in a better format. I had bad line feed charaters in the last patch causing the patch to replace the complete file.
Attachment #154727 - Attachment is obsolete: true
Comment on attachment 154823 [details] [diff] [review] patch - v2 makes highlight button reset close counter
Attachment #154823 - Flags: review?(firefox)
requesting blocking-aviary1.0PR since patch exists
Steffen, have you got a moment to check this one-liner in?
Checked into branch, with some added whitespace to make it look nicer. -> email@example.com.
Assignee: firefox → mikeclackler
Hardware: PC → All
Target Milestone: --- → Firefox1.0beta
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Whiteboard: [have patch]
Version: unspecified → 1.0 Branch
You need to log in before you can comment on or make changes to this bug.