Closed Bug 251686 Opened 20 years ago Closed 20 years ago

Composer duplicates code on save from HTML Source editing mode

Categories

(SeaMonkey :: Composer, defect, P1)

Product:
SeaMonkey
Component:
Composer
Platform:
x86
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.8alpha3

People

(Reporter: boofy_bloke, Assigned: neil)

References

Details

Attachments

(1 file)

Proposed patch
3.17 KB, patch
glazou
: review+
dmosedale
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040713
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040713

During the automatic switch from HTML view to NORMAL view, composer inserts a
copy  of the body (i.e. from [BODY] to [/BODY]).

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
It's worse than that: Composer adds the OLD body code to the new page.
Whiteboard: DUPEME
What automatic switch?
Why don't you fill in the steps to reproduce?

There is the HTML tags editing mode and the HTML source editing mode. Which one
are you referring to?
Can you give concrete steps to reproduce and what are the actual results?
FWIW, I can not find anything wrong with Composer when changing editing mode and
when saving a page from any editing mode.

WORKSFORME

Mozilla 1.8a3 build 2004071508 under XP Pro SP1a here.
If I CTRL+S when in HTML Source view, Composer saves and automatically switches
back to Normal view. Somewhere during this process, Composer adds the code from
before I saved onto the bottom of the code from after I saved.
I also have had the same problem.  OS = Windows XP Home. Build is Mozilla/5.0
(Windows; U; Windows NT 5.1; en-US; rv:1.8a3) Gecko/20040715
Steps to reproduce:
1.Open Composer 
2.Copy the following HTML to the HTML Source view.
<html>
<head>
<title>A Title</title>
</head>
<body>
<form action="test.html" method="post"> <input name="test" type="text"><input
type="submit">
</form>
</body>
</html>
3.Click the save button.
Those steps result in everything between the <body> and </body> to be
duplicated.  If you remove the <title>A Title</title> line from the code and
save it, the code is not duplicated
I can now see and confirm the problem with build 2004071609. I think step 2 in
comment #5 could be replaced by simply typing a single character into the code,
then Ctrl+S (or click Save button). Changing step 2 like that eliminates
possibility of clipboard involvement.
Step 3 would be to reopen HTML source editing mode and then typing another
character, then Ctrl+S (or click Save button).
I don't know if the duplication code behavior is in any way related to the
changing of editing mode after saving (Ctrl+S).

I note that you also filed bug 244226.

I need to check if there is another bugfile covering one or both behaviors
described in this bugfile.

*** Bug 252286 has been marked as a duplicate of this bug. ***
I could not find a duplicate for this bug.

CONFIRMING
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Composer duplicates page on save from HTML view → Composer duplicates code on save from HTML Source editing mode
Whiteboard: DUPEME
*** Bug 244226 has been marked as a duplicate of this bug. ***
*** Bug 252368 has been marked as a duplicate of this bug. ***
raising radar, this bug is a VERY severe feature blocker and makes Composer
source view totally unusable.
Flags: blocking1.8a3?
Priority: -- → P1
Target Milestone: --- → mozilla1.8alpha3
Attached patch Proposed patch — — Splinter Review 
SelectAll() got orphanned, it needs to be just before LoadHTML().
Assignee: composer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Comment on attachment 153871 [details] [diff] [review]
Proposed patch

sr=dmose
Attachment #153871 - Flags: superreview+
Fix checked in.

CCing mscott for completeness but this regression probably doesn't affect
Thunderbird because it already independently clears the body anyway.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Flags: blocking1.8a3?
Resolution: --- → FIXED
*** Bug 252234 has been marked as a duplicate of this bug. ***
*** Bug 252518 has been marked as a duplicate of this bug. ***
*** Bug 252566 has been marked as a duplicate of this bug. ***
*** Bug 252595 has been marked as a duplicate of this bug. ***
Confirm.

I downloaded and installed
  Mozilla 1.8 Alpha 2
(downloaded from the link on the front page http://www.mozilla.org/ )
and observed the bug.

I un-installed that, then downloaded and installed the Gecko/20040725 nightly
build from
http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/latest-trunk/mozilla-win32-installer.exe
.

It looks like you fixed the bug -- Thank you !

(Please update the front page so it no longer points to a version with this bug).

*** Bug 253640 has been marked as a duplicate of this bug. ***
*** Bug 253123 has been marked as a duplicate of this bug. ***
*** Bug 244833 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
This bug seems to be happening in Nvu 0.6 Aviary branch build 20041209.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: