Closed Bug 251735 Opened 20 years ago Closed 18 years ago

Make New Folder in Browse For Folders common dialog does not focus the new folder for rename

Categories

(Firefox :: Installer, defect)

x86
Windows XP
defect
Not set
minor

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: asa, Unassigned)

References

()

Details

(Whiteboard: [asaP1])

Attachments

(1 file)

On windows XP Firefox branch build 2004071609, in the custom install, broser for
folders, the "Make New Folder" button makes a new folder but does not move the
selection from the Program Files folder to the newly created folder. 
It should move the selection and put the new folder name in the rename state. 

Steps:
1. custom install
2. in the install folder panel of the installer, click "Browse".
3. Click "Make New Folder" 

Results: 
A new folder is created named "New Folder" but it is not focused so it's not
clear to the user (in the case that folders starting with the letter N are
scrolled out of view) that he has created a new folder. 

Also, if you click it again (as I did) thinking that you didn't succeed the
first time, a New Folder 2 is created and this one does get the focus and is put
into the rename state. You'll see right above it the previously created New Folder. 

Possibly some related commentary over at bug 229343 (though that is covering a
different issue, I think I saw a comment in there suggesting this wasn't working).
related bug filed here:
http://bugzilla.mozilla.org/show_bug.cgi?id=254961

Also I have noticed users click "make new folder" multiple times out of
frustration. Shud there be an option to delete/cancel the new folder? not sure
how other installers handle this. can research if needed. thx!
Summary: Make New Folder in Browser For Folders common dialog does not focus the new folder for rename → Make New Folder in Browse For Folders common dialog does not focus the new folder for rename
Blocks: 282239
No longer blocks: 282239
Blocks: 282239
Flags: blocking-aviary1.1?
Whiteboard: [asaP1]
We really should fix this. I'm sure the custom path is the minority case, but
for those that choose it, this is a painful bug. 
Flags: blocking1.8b4?
Of course, we're using a native Windows dialog, so the bug is in Windows and we
can't fix this.
Flags: blocking1.8b4?
Flags: blocking1.8b4-
Flags: blocking-aviary1.1?
(In reply to comment #3)
> Of course, we're using a native Windows dialog, so the bug is in Windows and we
> can't fix this.

Should it just be closed as "WONTFIX", then? 
*** Bug 302248 has been marked as a duplicate of this bug. ***
Assignee: bugs → nobody
QA Contact: bugzilla → installer
Version: 1.0 Branch → unspecified
I don't know whether this helps, but I see different behaviour for "Make New
Folder" since I changed my Windows system so that I am logged in as a
non-administrative user. Consequently I run the installater executable using
"Run As" on the context menu.

Run the installer executable as a non-administrative user:

Short summary: Make New Folder works correctly.
Details: After ignoring the warning that I do not have sufficient privileges,
choosing Custom Install, then Browse, I have the 'Program Files' directory
selected. 'Make New Folder' correctly warns me that I cannot create a new folder
here. After then selecting 'My Documents' and 'Make New Folder', I see the 'My
Documents' folder expanded, a 'New Folder' folder created, highlighted, and
selected, ready for me to type the name I want for the folder. After typing the
new name, the folder is selected. The new folder name is not in the "Folder:"
box but it is correctly reflected into the installation location after pressing OK.

Run the installer executable as an administrator:
After selecting Custom Install then Browse, 'Program Files' is selected. 'Make
New Folder' appears to do nothing, however navigating to the directory in
Windows Explorer shows that a folder 'New Folder' has been created. However it
doesn't appear in the selector unless I cancel and reopen the dialogue.
This was fixed (see attached screenshot - attachment 226768 [details])with the new installer that landed - bug 326580.
resolving -> wfm
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: