251782 - escape while focus in find toolbar stops page loading.

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Asa Dotzler [:asa]]

tested yesterday's branch build. if you try to dismiss the find toolbar while a
page is loading, both the dismiss toolbar and the stop page load are triggered.
This is bad. First escape if the toolbar is focused (the find field, at least)
should dismiss find and the second escape should stop page load.

Comment 1

[Kevin Brosnan]

*** Bug 254454 has been marked as a duplicate of this bug. ***

Comment 2

[:deanis74]

From bug 250587 comment 16, "I think that Esc should perform the act of the
closest bounding control.  If focus is in the Find toolbar, pressing Esc would
close it.  Then focus moves to the document, so pressing Esc again would cancel
page load."

Comment 3

[Blake Ross]

This is fixed as far as I can tell.

Comment 4

[:deanis74]

Yep, looks great in a branch build from 08/23.  Sorry, I should have checked
this one while I was going through others.

Comment 5

[:deanis74]

I may have spoken too soon.  If I am using FAYT the Find bar is never focus and
so pressing Esc stops the page from loading.  I notice there are a few bugs out
there where things behave differently whether using Edit > Find or FAYT.  I
think it would make things more consistent, and also fix bugs like this, if FAYT
focused the search bar.  That would probably wreck the search-start-of-links
feature.

Comment 6

[chris hofmann]

think this is going to have to fall of the list to get higher priority bugs for
1.0.   renominate if a patch appears in the next few weeks.

Comment 7

[Blake Ross]

Alright, try again.