Closed
Bug 251835
Opened 21 years ago
Closed 21 years ago
one line of redundant code in nsXPInstallManager.cpp
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect)
Core Graveyard
Installer: XPInstall Engine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cnst+bmo, Assigned: cnst+bmo)
Details
Attachments
(1 file)
|
1010 bytes,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Variable isPageLoading was introduced in version 1.124 (bug 238684), but is no
longer needed in version 1.123 (bug 242111). See the upcoming patch.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #153487 -
Flags: superreview?(jst)
Attachment #153487 -
Flags: review?(bsmedberg)
|
|
Assignee | |
Comment 2•21 years ago
|
||
(In reply to comment #0)
> Variable isPageLoading was introduced in version 1.124 (bug 238684), but is no
> longer needed in version 1.123 (bug 242111). See the upcoming patch.
"1.123" should read "1.125". :-)
Status: NEW → ASSIGNED
|
||
Comment 3•21 years ago
|
||
Comment on attachment 153487 [details] [diff] [review]
the patch
r+sr=jst. Email me if you need help with getting this checked in.
Attachment #153487 -
Flags: superreview?(jst)
Attachment #153487 -
Flags: superreview+
Attachment #153487 -
Flags: review?(bsmedberg)
Attachment #153487 -
Flags: review+
|
||
Comment 4•21 years ago
|
||
Checking in nsXPInstallManager.cpp;
/cvsroot/mozilla/xpinstall/src/nsXPInstallManager.cpp,v <-- nsXPInstallManager.cpp
new revision: 1.126; previous revision: 1.125
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•