251866 - Build fails with bad jar rule head at: pki/escrowWarn.js (make-jars.pl busted?)

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[tqh]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7) Gecko/20040606 Firefox/0.8.0+
Build Identifier: 

Build fails with the following under BeOS and AVIARY-branch:
+++ making chrome /Mozilla/mozilla/security/manager/pki/resources  =>
../../../../dist/bin/chrome/pippki.jar
bad jar rule head at: pki/escrowWarn.js             (content/escrowWarn.js)
make[3]: *** [libs] Error 255
make[3]: Leaving directory `/Mozilla/mozilla/security/manager/pki/resources'

I can not see anything in jar.mn that would suggest problems. Neither with the
files involved. Need advice. 

Reproducible: Always
Steps to Reproduce:
1. Build Firefox on BeOS

Actual Results:  
Build fails with "bad jar rule head at: pki/escrowWarn.js            
(content/escrowWarn.js)"

Expected Results:  
A full Firefox build.

Comment 1

[tqh]

Can't find what the real problem is. Commenting out escrowWarn.* in jar.mn just
moves the error to the next uncommented line. The files do exist. Suspect the
tool is broken (for BeOS).

Comment 2

[tqh]

Confirmed that it pukes on entry number 58 (I think), no matter what file it is.

Comment 3

[tqh]

Suspects make-jars.pl is broken for BeOS. 

Comment 4

[Bernd]

I see this on winxp too

+++ making chrome E:/moz_src/mozilla/obj-i586-pc-msvc/editor/ui  => ../../dist/b
in/chrome/comm.jar
+++ updating chrome ../../dist/bin/chrome/installed-chrome.txt
+++     content,install,url,jar:resource:/chrome/comm.jar!/content/editor/
+++ overriding content/editor/contents.rdf
updating: content/editor/contents.rdf (176 bytes security) (stored 0%)
bad jar rule head at: logs/locale/en-US/EditorInsertTable.dtd)  at e:/moz_src/mo
zilla/config/make-jars.pl line 522, <STDIN> line 189.
make[1]: *** [libs] Error 2
make[1]: Leaving directory `/cygdrive/e/moz_src/mozilla/obj-i586-pc-msvc/editor/
ui'
make: *** [all] Error 2

Comment 5

[tqh]

I've confirmation from two other that get the same error under BeOS. I have Perl
5.84 the others 5.80.

Comment 6

[Markus Doehr]

I'm seeing this under Windows XP too (since a few days)

Comment 7

[Bernd]

backing out the change for bug 248507 from July 8th does fix the issue for me

Comment 8

[Boris Zbarsky [:bzbarsky]]

To browser.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Ben, this is fallout from bug 248507.  I'm leaving the tree open for now, at
bernd's request, but this really falls into tree-closure type bustage in my
category (blocker on a Tier-1 platform).

Comment 10

[Benjamin Smedberg]

Is this trunk or aviary branch? Can I get details about perl versions (cygwin/AS
on windows). Since there are no preprocessor directives on the trunk, the
preprocessor "should" be passing the files through unmolested.

Comment 11

[Bernd]

It looks to me that the problem arises when more than one jar file is referenced
in a jar.mn file. There are some lines removed from stdin.
This is trunk seamonkey.
perl 5.8.0 activestate

Comment 12

[Bernd]

Ben, I can debug code for you on my machine if you need help to find it. So it
looks to me that when the empty line is encountered is updates the jar, but
looses characters ~ 800 of the jar.mn file. Then instead of working on the next
jar file it finds a strange directive and the make jars bails out.

Comment 13

[tqh]

For BeOS it's AVIARY-branch.

Comment 14

[Benjamin Smedberg]

Attachment: Read all of <STDIN> before processing

This appears mightily to be a perl bug... if you read from a <FILE> in the
middle of reading from <STDIN> the file position of stdin gets all out of
whack. This reads all of <STDIN> into a list before processing any of it.

Comment 15

[Benjamin Smedberg]

r=bz over IRC, and this fixes bernd's problem. Fun times with perl hackarounds!