251896 - incorrect inflation of system code page strings to UTF-16 in msgMapiHook.cpp

Status: RESOLVED WONTFIX

(MailNews Core :: Simple MAPI, defect)

Description

[Jungshik Shin]

mailnews/mapi/mapihook/src/msgMapiHook.cpp has a number of incorrect inflations
of strings in the system code page to UTF-16 with 'Assign/AppendWithConversion'.
This will only work for strings in ISO-8859-1. It doesn't even work for the C0
part (0x80 - 0x9f) of Windows 1252 on English/Western European windows.

They all should use  |NS_CopyNativeToUnicode|. 

BTW, when bug 239279 is fixed, we need to change all MAPI code to use 'W' APIs,
for which I'll file a separate bug.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

> |NS_CopyNativeToUnicode|.

strictly speaking, this is only guaranteed to work for filenames...
http://lxr.mozilla.org/seamonkey/source/xpcom/io/nsNativeCharsetUtils.h#48

Comment 2

[David :Bienvenu]

and that's what the code was doing before, as near as I can tell - trying to use
the file system charset, which didn't work at all for my test case.

Comment 3

[Jungshik Shin]

(In reply to comment #1)
> > |NS_CopyNativeToUnicode|.
> 
> strictly speaking, this is only guaranteed to work for filenames...
> http://lxr.mozilla.org/seamonkey/source/xpcom/io/nsNativeCharsetUtils.h#48

I guess you'd agree :-) that 'filenames' in the comment can be (loosely)
interpreted as C strings that  come out_of Win32 'A' APIs (at least for the now).  

 
 

Comment 4

[Jungshik Shin]

Attachment: patch (not yet tested)

David, can you tell me how to test MAPI? 

I replaced all 'WithConversion's with 'NS_CopyNativeToUnicode' assuming that
they can have non-ASCII characters in the system default encoding. It seems
that 'To', 'Cc', 'From' etc include 'names' as well as addresses so that they
can have non-ASCII characters.

Comment 5

[Jungshik Shin]

*** Bug 250481 has been marked as a duplicate of this bug. ***

Comment 6

[David :Bienvenu]

one way to test mapi is to build and run the mapi test app,
mailnews/mapi/old/tests/mapitest - open the project in visual studio and build
and run it (after first setting tbird/mozilla to be the default mail client)

Comment 7

[buovjaga]

The thing used now is Append(NS_ConvertASCIItoUTF16()) https://hg.mozilla.org/comm-central/file/tip/mailnews/mapi/mapihook/src/msgMapiHook.cpp

So the original proposal does not apply anymore. Closing as WONTFIX for lack of better status.