252137 - tabular reports are broken if a row/col/tbl header begins with an underscore

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Rob Siklos [:robzilla]]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: 

Since the template toolkit hides values of hash keys beginning with a '.' or 
a '_', the tabular reports get broken if a table, column, or row header name 
begins with a [._].  For instance, I have a component name called 
_Unspecified.  If I run a tabular report on this field, I get a bunch of errors 
in the apache log, and all the entries in the table for _Unspecified are blank.

I fixed this problem by adding a space to the front of the names if they start 
with [._].

In report.cgi near line 170:
...
    $row = "" if ($row eq $columns{''});
    $col = "" if ($col eq $columns{''});
    $tbl = "" if ($tbl eq $columns{''});

    # account for the fact that names may start with '_' or '.'.  Change this 
    # so the template doesn't hide hash elements with those keys
    $row =~ s/^([._])/ $1/;
    $col =~ s/^([._])/ $1/;
    $tbl =~ s/^([._])/ $1/;
    
    $data{$tbl}{$col}{$row}++;
    $names{"col"}{$col}++;
    $names{"row"}{$row}++;
    $names{"tbl"}{$tbl}++;
...


Reproducible: Always
Steps to Reproduce:

Comment 1

[Rob Siklos [:robzilla]]

Attachment: Patch v1

Comment 2

[Dave Miller [:justdave]]

tabular reports did not yet exist in 2.16, so this can't block 2.16 :)

I seem to recall something to do with underscores being fixed already in charts,
but since this is reported against 2.18 (pretty recent) maybe it was something
else...

Gerv?

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 161058 [details] [diff] [review]
Patch v1

r=gerv. Indeed, this does fix a problem.

Gerv

Comment 4

[Vlad Dascalu]

Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.26; previous revision: 1.25
done

Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.24.2.1; previous revision: 1.24
done