In <pageInfoOverlay.js>, "Warning: reference to undefined property elts[i][aAttrName]"

RESOLVED FIXED

Status

SeaMonkey
Page Info
--
minor
RESOLVED FIXED
13 years ago
11 years ago

People

(Reporter: sgautherie, Assigned: florian)

Tracking

(4 keywords)

Trunk
x86
Windows 98
fixed-seamonkey1.0, fixed-seamonkey1.1a, fixed1.8.1, verified1.8.0.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a2) Gecko/20040714] (release) (W98SE)

{{
Warning: reference to undefined property elts[i][aAttrName]
Source File: chrome://p3p/content/pageInfoOverlay.js
Line: 139
}}

Seen this once: not reproduced...
This is in the wrong component, but I can't remember off hand where P3P bugs go.
Product: Browser → Seamonkey
(Assignee)

Comment 2

12 years ago
Created attachment 195667 [details] [diff] [review]
patch v1

I'm not sure if it's the same bug or not, but I get a javascript error caused
by the same line in pageInfoOverlay.js when I open Page Info on a webpage
containing this html code:
<form action="action.php" method="post">
 <select name="action" id="action" ...

The attached patch should fix this and maybe the warning originaly reported.
Assignee: db48x → f.qu
Status: NEW → ASSIGNED
Attachment #195667 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #195667 - Flags: review?(db48x)
Comment on attachment 195667 [details] [diff] [review]
patch v1

looks good, r=db48x
Attachment #195667 - Flags: review?(db48x) → review+
(Reporter)

Comment 4

12 years ago
(In reply to comment #2)
> I'm not sure if it's the same bug or not,

I never noticed this warning after my initial report;
then you'll be free to resolve this bug when you checkin your patch :-)

Comment 5

12 years ago
Comment on attachment 195667 [details] [diff] [review]
patch v1

Instead of .attributes[attrName).value can't you use .getAttribute(attrName) ?
(Assignee)

Comment 6

12 years ago
Created attachment 197288 [details] [diff] [review]
patch v2 (checked in trunk/branch 1.8 & 1.8.0)

(In reply to comment #5)
> (From update of attachment 195667 [details] [diff] [review] [edit])
> Instead of .attributes[attrName).value can't you use .getAttribute(attrName)
?
> 

yes :-)
Attachment #195667 - Attachment is obsolete: true
Attachment #197288 - Flags: superreview?(neil.parkwaycc.co.uk)
(Assignee)

Updated

12 years ago
Attachment #195667 - Flags: superreview?(neil.parkwaycc.co.uk)

Updated

12 years ago
Attachment #197288 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
checked in
(Reporter)

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Attachment #197288 - Flags: approval-seamonkey1.0?

Comment 8

12 years ago
Comment on attachment 197288 [details] [diff] [review]
patch v2 (checked in trunk/branch 1.8 & 1.8.0)

a=me, you will need at least one more

Updated

12 years ago
Attachment #197288 - Flags: approval-seamonkey1.1+
Attachment #197288 - Flags: approval-seamonkey1.0?
Attachment #197288 - Flags: approval-seamonkey1.0+

Comment 9

12 years ago
Comment on attachment 197288 [details] [diff] [review]
patch v2 (checked in trunk/branch 1.8 & 1.8.0)

Checking in (branch 1.8)
pageInfoOverlay.js;
new revision: 1.3.28.2; previous revision: 1.3.28.1
done
Checking in (branch 1.8.0)
pageInfoOverlay.js;
new revision: 1.3.28.1.2.1; previous revision: 1.3.28.1
done
Attachment #197288 - Attachment description: patch v2 → patch v2 (checked in trunk/branch 1.8 & 1.8.0)

Updated

12 years ago
Whiteboard: fixed-seamonkey1.0

Updated

12 years ago
Keywords: fixed1.8.0.1, fixed1.8.1

Comment 10

12 years ago
Do we have a sample url or testcase that we can use to verify this fix?  Can anyone here verify the fix with the latest 1.8.0 and/or 1.8.1 build?
(Reporter)

Comment 11

12 years ago
(In reply to comment #10)
> Do we have a sample url or testcase that we can use to verify this fix?

"No", it seems comment 2 is the closest...
(Assignee)

Comment 12

12 years ago
(In reply to comment #10)
> Do we have a sample url or testcase that we can use to verify this fix?  Can
> anyone here verify the fix with the latest 1.8.0 and/or 1.8.1 build?
> 

My patch was for the bug that we had in the "Privacy" tab with this url: http://rtgamer.free.fr/
(there is a form field named "action").

Comment 13

12 years ago
v.fixed on 1.8.0.1 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1, no js erros in console when viewing page info for the url in Florian's comment #12
Keywords: fixed1.8.0.1 → verified1.8.0.1
(Reporter)

Updated

12 years ago
Keywords: fixed-seamonkey1.0
Whiteboard: fixed-seamonkey1.0

Updated

11 years ago
Keywords: fixed-seamonkey1.1a
You need to log in before you can comment on or make changes to this bug.