252201 - In <pageInfoOverlay.js>, "Warning: reference to undefined property elts[i][aAttrName]"

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a2) Gecko/20040714] (release) (W98SE)

{{
Warning: reference to undefined property elts[i][aAttrName]
Source File: chrome://p3p/content/pageInfoOverlay.js
Line: 139
}}

Seen this once: not reproduced...

Comment 1

[Daniel Brooks [:db48x]]

This is in the wrong component, but I can't remember off hand where P3P bugs go.

Comment 2

[Florian Quèze [:florian]]

Attachment: patch v1

I'm not sure if it's the same bug or not, but I get a javascript error caused
by the same line in pageInfoOverlay.js when I open Page Info on a webpage
containing this html code:
<form action="action.php" method="post">
 <select name="action" id="action" ...

The attached patch should fix this and maybe the warning originaly reported.

Comment 3

[Daniel Brooks [:db48x]]

Comment on attachment 195667 [details] [diff] [review]
patch v1

looks good, r=db48x

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> I'm not sure if it's the same bug or not,

I never noticed this warning after my initial report;
then you'll be free to resolve this bug when you checkin your patch :-)

Comment 5

[[e-mail]]

Comment on attachment 195667 [details] [diff] [review]
patch v1

Instead of .attributes[attrName).value can't you use .getAttribute(attrName) ?

Comment 6

[Florian Quèze [:florian]]

Attachment: patch v2 (checked in trunk/branch 1.8 & 1.8.0)

(In reply to comment #5)
> (From update of attachment 195667 [details] [diff] [review] [edit])
> Instead of .attributes[attrName).value can't you use .getAttribute(attrName)
?
> 

yes :-)

Comment 7

[Daniel Brooks [:db48x]]

checked in

Comment 8

[Ian Neal]

Comment on attachment 197288 [details] [diff] [review]
patch v2 (checked in trunk/branch 1.8 & 1.8.0)

a=me, you will need at least one more

Comment 9

[Ian Neal]

Comment on attachment 197288 [details] [diff] [review]
patch v2 (checked in trunk/branch 1.8 & 1.8.0)

Checking in (branch 1.8)
pageInfoOverlay.js;
new revision: 1.3.28.2; previous revision: 1.3.28.1
done
Checking in (branch 1.8.0)
pageInfoOverlay.js;
new revision: 1.3.28.1.2.1; previous revision: 1.3.28.1
done

Comment 10

[Jay Patel [:jay]]

Do we have a sample url or testcase that we can use to verify this fix?  Can anyone here verify the fix with the latest 1.8.0 and/or 1.8.1 build?

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)
> Do we have a sample url or testcase that we can use to verify this fix?

"No", it seems comment 2 is the closest...

Comment 12

[Florian Quèze [:florian]]

(In reply to comment #10)
> Do we have a sample url or testcase that we can use to verify this fix?  Can
> anyone here verify the fix with the latest 1.8.0 and/or 1.8.1 build?
> 

My patch was for the bug that we had in the "Privacy" tab with this url: http://rtgamer.free.fr/
(there is a form field named "action").

Comment 13

[Jay Patel [:jay]]

v.fixed on 1.8.0.1 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1, no js erros in console when viewing page info for the url in Florian's comment #12