252352 - cannot position caret in search bar text with mouse, selects all on click

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Tuukka Tolvanen (sp3000)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040718 Firefox/0.9.1+
Build Identifier: linux thunderbird aviary 2004-07-20-18Z

Cannot position caret in search bar text with mouse, instead it selects all of
the text in it on every click. Arguably it should select all on focus, although
the location and search bars in firefox don't, at least on linux.

Reproducible: Always
Steps to Reproduce:
1. view > toolbars > search bar, in case it was hidden
2. type text into search textfield
3. try to position caret into text by clicking
Actual Results:  
selects all text in search field

Expected Results:  
position caret to clicked position in search field text

Comment 1

[Tuukka Tolvanen (sp3000)]

> the text in it on every click. Arguably it should select all on focus, although
> the location and search bars in firefox don't, at least on linux.

...that is, they do on focus by keynav, not on focus by mouse click.

Comment 2

[Jerry Baker]

OS -> ALL

Seeing this on Windows XP.

Comment 3

[Jerry Baker]

I have fixed this problem so that it behaves identically to the browser URL bar.
I will attach the patch in a while.

Comment 4

[Jerry Baker]

Attachment: Patch to make the search bar behave like the URL bar

The only questionable thing I see about this patch is that the setting is not a
pref as it is in the browser, but I think it would be an extremely minor issue
to not be able to control whether the first click selects the text or not.

Comment 5

[Jerry Baker]

*** Bug 228112 has been marked as a duplicate of this bug. ***

Comment 6

[Scott MacGregor]

this patch isn't for thunderbird it's for the suite. 

Comment 7

[Jerry Baker]

Well, I tried to find a Thunderbird branch, but I didn't see one. The developer
pages on mozilla.org have no mention of such a beast. Where is it and I will
make a patch. Then someone needs to update the developer pages.

Comment 8

[Jerry Baker]

Plus LXR shows only one file for searchbar.js and mailoverlaywindow.xul. Are
there hidden ones somewhere else that LXR doesn't know about?

Comment 9

[Jerry Baker]

I followed the instructions at
http://www.mozilla.org/projects/thunderbird/build.html and still get the same
files. WTF?

Comment 10

[Scott MacGregor]

mozilla\mail\base\content\searchBar.js
mozilla\mail\base\content\mailWindowOverlay.xul

Comment 11

[Jerry Baker]

Those are the files I patched against.

Comment 12

[Scott MacGregor]

no your patch is against the seamonkey files in mailnews. That's not where the
thunderbird UI lives. That's where the seamonkey UI lives. I didn't list two
files in mailnews :)

Comment 13

[Jerry Baker]

Tried to pull mail/ and I get:

mozilla/client.mk(92) : fatal error U1033: syntax error : '=' unexpected

Comment 14

[Scott MacGregor]

*sigh* did you read the build instructions?

www.mozilla.org/projects/thunderbird/build.html

Comment 15

[Jerry Baker]

*BIGGER SIGH* That's HOW I ran into the error.

Comment 16

[Jerry Baker]

D:\Mozilla>cvs co mozilla/client.mk mozilla/mail/config
cvs checkout: Updating mozilla/mail/config

D:\Mozilla>nmake -f mozilla/client.mk pull_all

Microsoft (R) Program Maintenance Utility   Version 6.00.8168.0
Copyright (C) Microsoft Corp 1988-1998. All rights reserved.

mozilla/client.mk(92) : fatal error U1033: syntax error : '=' unexpected
Stop.

Comment 17

[Jerry Baker]

Attachment: Patch against Thunderbird source

Had to manually check out each file. client.mk for Thunderbird is broken.

Comment 18

[Jerry Baker]

Argh. Flex=5 in my 20040807 build, but now it's flex=1.

Comment 19

[Jerry Baker]

Attachment: Once more...

Comment 20

[Jerry Baker]

Attachment: Is it right...

Maybe I'll get the patch up-to-date before the spam police come knocking at my
door.

Comment 21

[Jerry Baker]

Attachment: Newest

Stop me before I patch again

Comment 22

[Jerry Baker]

Attachment: No one stopped me...

This has been tested by applying it to the Thunderbird tree. Modified function
names to be inline with naming conventions in searchBar.js, and fixed the
onSearchInputFocus() function.

It should now be fully ready. I am testing this patch on my local build and
haven't seen any issues.

Sorry for all the spam as I figure out this thing.

Comment 23

[Jerry Baker]

Forgive my questions, but I am new to this.

I know how to read a preference, and write a preference, but what is the proper
way to create a new preference? I have a patch that reads a boolean preference
called mail.searchbar.clickSelectsAll, and that is working fine. I just don't
know the proper procedure for creating a new preference in Thunderbird. Is it as
simple as creating a default value, adding an entry to thunderbird.js, and then
setting up the code to read the pref?

Comment 24

[Jerry Baker]

What I mean, is how do you get it so that Thunderbird is aware of this
preference and know its default value if it does not exist in prefs.js?

Comment 25

[Jerry Baker]

Attachment: Patch against Thunderbird Tree with pref

Take your pick...pref or no pref

Comment 26

[Scott MacGregor]

I haven't had a chance to play around with this patch yet. Still fighting lots
of focus issues with the search box so I'm loathe to take on more risk for that
right now. May move this back to 1.0 after 0.9 is done if I have time.

Comment 27

[Thomas Rutter]

*** Bug 256666 has been marked as a duplicate of this bug. ***

Comment 28

[Scott MacGregor]

Attachment: updated version of the fix

I simplified a couple things from the original patch.

Comment 29

[Scott MacGregor]

fix checked in. thanks for the patch!

Comment 30

[Mike Cowperthwaite]

I'm afraid I'm mystified by LXR.  Did this make it into the suite?
(see bug 283961).

I do see it fixed in today's TB build.

Comment 31

[Mike Cowperthwaite]

*** Bug 274047 has been marked as a duplicate of this bug. ***

Comment 32

[Stephen Donner [:stephend] Not actively reading bugmail]

Mike: suite doesn't use mail/base that I know of, it still uses mailnews.

However, TB uses mailnews/base, afaik.

Comment 33

[Scott MacGregor]

i forgot to mark this fixed