Provide edit link for attachment in comment

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Creating/Changing Bugs
RESOLVED FIXED
14 years ago
6 years ago

People

(Reporter: Christian Reis, Assigned: Christian Reis)

Tracking

unspecified
Bugzilla 2.18
Bug Flags:
approval +
approval2.18 +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

14 years ago
It's a hassle to be reading comments and then need to scroll back to the top of
the page to be able to edit an attachment. A simple edit link next to the
attachment name would improve usability. Patch coming up.
(Assignee)

Comment 1

14 years ago
Created attachment 153849 [details] [diff] [review]
kiko_v1: add edit link

See http://www.async.com.br/~kiko/mybugzilla/show_bug.cgi?id=3 for example.
(Assignee)

Updated

14 years ago
Attachment #153849 - Flags: review?(bugreport)

Updated

14 years ago
Attachment #153849 - Flags: review?(bugreport) → review+
(Assignee)

Comment 2

14 years ago
Glob suggested following [reply] and adding square brackets; I don't care either
way (and I want to change [reply] to be in a table cell and aligned
consistently) but I can change it while checking in if approved.
Status: NEW → ASSIGNED
Flags: approval?
Interesting...  this is going to add the (edit) link after any "attachment ####"
that gets linkified in a comment, too.  Was that intentional?  Myk, how's your
take on it?  (UI change)
(Assignee)

Comment 4

14 years ago
Created attachment 153914 [details] [diff] [review]
option 2: only add (edit) to attachment creation link.

That was actually unintentional. I'm not sure which is more correct, because I
don't have a lot of experience with observing people using attachment links
(they are rarely used outside Bugzilla IME), so I'm attaching this one, and
feel free to approve any one of them you like.
(Assignee)

Updated

14 years ago
Attachment #153849 - Attachment is obsolete: true
(Assignee)

Comment 5

14 years ago
Comment on attachment 153914 [details] [diff] [review]
option 2: only add (edit) to attachment creation link.

See what you think of either one.
Attachment #153914 - Flags: review?(myk)
I suspect that a better solution is to make the attachment link itself go to the
edit page.  From there the other attachment views (raw and diff) are one click
away, albeit not very noticably (but that can be fixed in another bug).

This would be a change to longstanding functionality, so people may complain,
but others may praise, and it's worth it if the majority of people want the edit
page when they click an attachment link.
(In reply to comment #6)
> I suspect that a better solution is to make the attachment link itself go to 
> the edit page.

But an "(edit)" link is a good solution for the iterim at least and gives us a
chance to see what people think.  Version one that puts the link everywhere
approved.
Flags: approval? → approval+
Attachment #153914 - Flags: review?(myk)
(Assignee)

Updated

14 years ago
Attachment #153914 - Attachment is obsolete: true
(Assignee)

Comment 8

14 years ago
Created attachment 154160 [details] [diff] [review]
kiko_v2: remove view, unnecessary and inconvenient for shell pasting
This simple, low-risk usability fix should go into 2.18.
Flags: approval2.18+
(Assignee)

Comment 10

14 years ago
Checked into branch and trunk. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Question: how do I localize the word "edit", which we're now inserting in
comment bodies after attachment links....?  I understand grandfathering existing
hard-coded stuff (like "attachment" and "bug") in quoteUrls, but weren't we
trying to avoid adding new non-localizable content?
(Assignee)

Comment 12

14 years ago
The only way I see we could do it is providing a template block that would be
processed every time an attachment or bug was encountered. I'm not sure if that
would hurt us performance-wise, but I'd be happy to implement this for our
Get*Link functions if it's decided it's how it should be.
Given that we start off by searching for the string 'attachment' in the first
place, I'm not sure that localising 'edit' is really the top priority here...
(In reply to comment #13)
> Given that we start off by searching for the string 'attachment' in the first
> place, I'm not sure that localising 'edit' is really the top priority here...

Brad has a point here.  This can be tackled when we do i18n for GetBugLink :)
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.