252424 - Clicking on "view saved passwords" gennerates xml parsing error

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[matsuba]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.7) Gecko/20040704 Firefox/0.9.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.7) Gecko/20040704 Firefox/0.9.1

Malformed Checkin by bsmedberg%covad.net 2004-07-19 15:38,
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/locales/en-US/chrome/passwordmgr&command=DIFF_FRAMESET&file=passwordManager.dtd&rev1=1.1&rev2=1.1.2.1&root=/cvsroot


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[matsuba]

Attachment: patch for passwordManager.dtd

mozilla/toolkit/locales/en-US/chrome/passwordmgr/passwordManager.dtd

Comment 2

[matsuba]

This is my first patch.. 


+   - The Original Code is mozilla.org configuration viewer.
+   -
+   - The Initial Developer of the Original Code is
+   - Netscape Communications Corporation.
+   - Portions created by the Initial Developer are Copyright (C) 2002
+   - the Initial Developer. All Rights Reserved.
+   -

Probably, it is wrong. Please correct it.

Comment 3

[matsuba]

Attachment: update patch

Comment 4

[matsuba]

Attachment: patch for Mozilla 1.x

Comment 5

[Steffen Wilberg]

*** Bug 252579 has been marked as a duplicate of this bug. ***

Comment 6

[Steffen Wilberg]

Confirming and taking. Copying summary from bug 252579 since describes the
problem caused by this.

Comment 7

[Steffen Wilberg]

Comment on attachment 153881 [details] [diff] [review]
update patch

The #-sytle comments are widely used in browser and toolkit. "# " tells the
preprocessor to strip the line. But file needs to be preprocessed, which is
done by a * in the respective jar.mn.

Comment 8

[Steffen Wilberg]

Comment on attachment 153882 [details] [diff] [review]
patch for Mozilla 1.x

This patch is not for Mozilla 1.x, but for the Firefox trunk...
Please also use "cvs diff -u8" to create patches.

Comment 9

[Steffen Wilberg]

I just checked a fix into the branch:
http://bonsai.mozilla.org/cvsquery.cgi?branch=&date=explicit&mindate=2004-07-22+05%3A15&maxdate=2004-07-22+05%3A15

The trunk is not affected.

Comment 10

[matsuba]

Attachment: patch1

mozilla/toolkit/locales/en-US/chrome/passwordmgr/

Comment 11

[matsuba]

Attachment: patch2

mozilla/toolkit/components/passwordmgr/resources/locale/passwordManager

Comment 12

[matsuba]

I'm sorry, New patch is avaiable.

Comment 13

[Steffen Wilberg]

Matsuba, I'm sorry you misunderstood me. I suggested you use cvs diff _in the
future, in future bugs_, because this bug is already fixed. See the link in
comment 9. The fix is not in changing the comment style, but in making these
files preprocessed. This is done by adding a "*" in the jar.mn.

Comment 14

[matsuba]

(In reply to comment #13)
> Matsuba, I'm sorry you misunderstood me. I suggested you use cvs diff _in the
> future, in future bugs_, because this bug is already fixed. See the link in
> comment 9. The fix is not in changing the comment style, but in making these
> files preprocessed. This is done by adding a "*" in the jar.mn.

I certainly understood. Thanks for your reply. 

Comment 15

[matsuba]

Please answer my question. Many localizers are confued by this solution ?
Normally, DTD's comment style:

Begin with : <!-- Text 
End with:        -->

Please see. http://www.mozilla.org/projects/l10n/mlp_chrome.html#text

Comment 16

[Steffen Wilberg]

You're right. But "# " is valid as well, if the file is preprocessed. It's a
whole line comment (from the first character): # Text Text.
The preprocessor removes lines starting with "# ". You won't see these lines in
en-US.jar. Download a nightly build from today, once it is available, and you'll
see that the license has been completely removed from passwordManager.dtd in
en-US.jar. In other words: Don't care about this, it's OK.

Comment 17

[matsuba]

Thanks again. I understood very well.